feat: consolidate statsd config to a single environment variable of SNUBA_STATSD_ADDR (#7524)

Author: aldy505

snuba/settings/__init__.py

@@ -14,6 +14,7 @@
 )
 
 from snuba.settings.validation import validate_settings
+from snuba.utils.metrics.addr_config import get_statsd_addr
 
 # All settings must be uppercased, have a default value and cannot start with _.
 # The Rust consumer relies on this to create a JSON file from the evaluated settings
@@ -122,8 +123,7 @@
 ]
 
 # Dogstatsd Options
-DOGSTATSD_HOST: str | None = os.environ.get("SNUBA_STATSD_HOST") or None
-DOGSTATSD_PORT: int | None = int(os.environ.get("SNUBA_STATSD_PORT") or 0) or None
+DOGSTATSD_HOST, DOGSTATSD_PORT = get_statsd_addr()
 DOGSTATSD_SAMPLING_RATES = {
     "metrics.processor.set.size": 0.1,
     "metrics.processor.distribution.size": 0.1,

snuba/settings/settings_docker.py

@@ -1,5 +1,7 @@
 import os
 
+from snuba.utils.metrics.addr_config import get_statsd_addr
+
 env = os.environ.get
 
 DEBUG = env("DEBUG", "0").lower() in ("1", "true")
@@ -13,8 +15,7 @@
 USE_REDIS_CLUSTER = False
 
 # Dogstatsd Options
-DOGSTATSD_HOST = env("DOGSTATSD_HOST")
-DOGSTATSD_PORT = env("DOGSTATSD_PORT")
+DOGSTATSD_HOST, DOGSTATSD_PORT = get_statsd_addr()
 
 SENTRY_DSN = env("SENTRY_DSN")
 

snuba/settings/settings_self_hosted.py

@@ -1,6 +1,8 @@
 import os
 from typing import Set
 
+from snuba.utils.metrics.addr_config import get_statsd_addr
+
 env = os.environ.get
 
 ALLOCATION_POLICY_ENABLED = False
@@ -17,8 +19,7 @@
 USE_REDIS_CLUSTER = False
 
 # Dogstatsd Options
-DOGSTATSD_HOST = env("DOGSTATSD_HOST")
-DOGSTATSD_PORT = env("DOGSTATSD_PORT")
+DOGSTATSD_HOST, DOGSTATSD_PORT = get_statsd_addr()
 
 # Dataset readiness states supported in this environment
 SUPPORTED_STATES: Set[str] = {"deprecate", "complete"}

snuba/utils/metrics/addr_config.py

@@ -0,0 +1,18 @@
+import os
+from typing import Optional
+
+
+def get_statsd_addr() -> tuple[Optional[str], Optional[int]]:
+    """Returns the address of the StatsD server."""
+    snuba_statsd_address = os.environ.get("SNUBA_STATSD_ADDR")
+    if snuba_statsd_address:
+        ip, separator, port = snuba_statsd_address.rpartition(":")
+        assert separator == ":", "SNUBA_STATSD_ADDR must be in the format of ip:port"
+        return ip, int(port or 8125)
+
+    dogstatsd_host = os.environ.get("DOGSTATSD_HOST")
+    dogstatsd_port = os.environ.get("DOGSTATSD_PORT", "8125")
+    if dogstatsd_host and dogstatsd_port:
+        return dogstatsd_host, int(dogstatsd_port)
+
+    return None, None