Skip to content

Conversation

@untitaker
Copy link
Member

@untitaker untitaker commented Jan 24, 2025

All of our tests are segmented by whether they need clickhouse to run or not, using the clickhouse_db marker. All the tests that do not need clickhouse don't need to be re-run in test_distributed.

Also refactor test matrix so we have fewer conditional steps.

All of our tests are segmented by whether they need clickhouse to run or not. All the tests that do not need clickhouse don't need to be re-run in test_distributed.

Also refactor test matrix so we have fewer conditional steps.
@untitaker untitaker requested a review from a team as a code owner January 24, 2025 17:08
@codecov
Copy link

codecov bot commented Jan 24, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2860 1 2859 11
View the top 1 failed tests by shortest run time
tests.utils.test_check_clickhouse::test_filter_checked_storages
Stack Traces | 0.462s run time
Traceback (most recent call last):
  File ".../tests/utils/test_check_clickhouse.py", line 190, in test_filter_checked_storages
    assert errors_storage in storages
AssertionError: assert <snuba.datasets.storage.ReadableTableStorage object at 0x7f600f931ad0> in [<snuba.datasets.storage.ReadableTableStorage object at 0x7f5fe2de8e90>]

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@untitaker untitaker marked this pull request as draft January 24, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants