Skip to content

fix: shortcircuit for storages with no allocaiton policies #7458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: shortcircuit for storages with no allocaiton policies #7458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion snuba/web/db_query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
from snuba.downsampled_storage_tiers import Tier
from snuba.query import ProcessableQuery
from snuba.query.allocation_policies import (
DEFAULT_PASSTHROUGH_POLICY,
MAX_THRESHOLD,
AllocationPolicy,
AllocationPolicyViolations,
Expand Down Expand Up @@ -809,7 +810,7 @@ def _apply_allocation_policies_quota(
Sets the resource quota in the query_settings object to the minimum of all available
quota allowances from the given allocation policies.
"""
if len(allocation_policies) == 0:
if allocation_policies == [DEFAULT_PASSTHROUGH_POLICY]:
logger.info("No allocation policies to apply")
return

Expand Down
Loading