fix(deletes): some ch versions dont have setting #7536
Merged
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onewland
approved these changes
Nov 13, 2025
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
101
to
103
| lw_sync = get_int_config("lightweight_deletes_sync") | ||
| if lw_sync: | ||
| query_settings.set_clickhouse_settings({"lightweight_deletes_sync": lw_sync}) |
There was a problem hiding this comment.
Bug: The change to get_int_config removes the default, causing lightweight_deletes_sync to be None and not set, leading to a KeyError in test_clickhouse_settings.
Severity: CRITICAL | Confidence: 1.00
🔍 Detailed Analysis
The get_int_config("lightweight_deletes_sync") call in the new code returns None when the config is not explicitly set, unlike the old code which defaulted to 2. This causes the if lw_sync: condition to evaluate to False, preventing query_settings.set_clickhouse_settings() from being called. Consequently, the test_clickhouse_settings assertion assert clickhouse_settings["lightweight_deletes_sync"] == 2 fails with a KeyError because the lightweight_deletes_sync key is missing from clickhouse_settings.
💡 Suggested Fix
Update test_clickhouse_settings to align with the new behavior where lightweight_deletes_sync is only set if explicitly configured, or reintroduce a default value to get_int_config if the old behavior is intended.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: snuba/lw_deletions/strategy.py#L101-L103
Potential issue: The `get_int_config("lightweight_deletes_sync")` call in the new code
returns `None` when the config is not explicitly set, unlike the old code which
defaulted to `2`. This causes the `if lw_sync:` condition to evaluate to `False`,
preventing `query_settings.set_clickhouse_settings()` from being called. Consequently,
the `test_clickhouse_settings` assertion `assert
clickhouse_settings["lightweight_deletes_sync"] == 2` fails with a `KeyError` because
the `lightweight_deletes_sync` key is missing from `clickhouse_settings`.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference_id: 2665648
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES SNUBA-9X1
Although this wont be an issue once all the clusters are upgraded https://github.com/getsentry/ops/pull/17973