-
Notifications
You must be signed in to change notification settings - Fork 519
App Submission: jupyterlab #3942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
App Submission: jupyterlab #3942
Conversation
al-lac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Mr-Sunglasses,
really great submission for a really useful and powerful app! 👏
Only have some comments about the versioning, the rest is flawless ⭐
Tested it on my Umbrel dev instance and it worked perfectly fine.
Co-authored-by: Alexander L. <[email protected]>
Co-authored-by: Alexander L. <[email protected]>
🎉 Linting finished with no errors or warnings 🎉Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store. |
Thanks a lot @al-lac for the review. I've done to necessary changes, 😄 . |
Awesome, thanks for making these changes so quickly ⚡ Tested it again and still works fine with the new image. Lets prepare the gallery assets now 🎨 |
App Submission
App name (required)
JupyterLab
256x256 SVG icon (required)
Gallery images (required)
I have tested my app on (check at least one):