-
Notifications
You must be signed in to change notification settings - Fork 520
App Submission: tubearchivist #3944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
al-lac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Mr-Sunglasses,
another really great submission of yours. Love the use case for this app. 🎥
Tested the app on my Umbrel dev instance, works without any issues 🔝
Added some comments on what should be adjusted to get this app ready for primetime.
Co-authored-by: Alexander L. <[email protected]>
Co-authored-by: Alexander L. <[email protected]>
Co-authored-by: Alexander L. <[email protected]>
Co-authored-by: Alexander L. <[email protected]>
Co-authored-by: Alexander L. <[email protected]>
Co-authored-by: Alexander L. <[email protected]>
Thanks a lot @al-lac for the review. I've done to necessary changes, 😄 . |
|
Great job on making the adaptions @Mr-Sunglasses, thanks! 🥇 Lets create the gallery assets now. |
|
| Severity | File | Description |
|---|---|---|
| ℹ️ | tubearchivist/docker-compose.yml |
Potentially using unsafe user in service "server": The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000. |
tubearchivist/umbrel-app.yml |
"icon" and "gallery" needs to be empty for new app submissions: The "icon" and "gallery" fields must be empty for new app submissions as it is being created by the Umbrel team. |
Legend
| Symbol | Description |
|---|---|
| ❌ | Error: This must be resolved before this PR can be merged. |
| Warning: This is highly encouraged to be resolved, but is not strictly mandatory. | |
| ℹ️ | Info: This is just for your information. |
|
Hey @Mr-Sunglasses, thanks for another amazing submission! Great addition to the app store. 📹 I updated it to the latest version and made minor adjustments. Tested it as well and we are ready to go live now! 🚀
|

fix: #3749
App Submission
App name (required)
tubearchivist
256x256 SVG icon (required)
Gallery images (required)
I have tested my app on (check at least one):