-
Notifications
You must be signed in to change notification settings - Fork 518
App Submission: fx #3956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
App Submission: fx #3956
Conversation
🎉 Linting finished with no errors or warnings 🎉Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store. Please review the linting results below and make any necessary changes to your submission. Linting Results
Legend
|
al-lac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Mr-Sunglasses,
really nice submission! ✍️
For some reason I cannot login on the Web UI, I get a 303 error in the Browser Console and I am just back at the start page. Does it work for you?
| APP_PORT: "3000" | ||
| PROXY_AUTH_ADD: "false" | ||
| web: | ||
| image: rikhuijzer/fx:1@sha256:af28e5b7c9d7aec1a534d1525719b7a566f64376d778bffc45231a077096898f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use of same version for image.
| image: rikhuijzer/fx:1@sha256:af28e5b7c9d7aec1a534d1525719b7a566f64376d778bffc45231a077096898f | |
| image: rikhuijzer/fx:1.2.1@sha256:af28e5b7c9d7aec1a534d1525719b7a566f64376d778bffc45231a077096898f |
| PROXY_AUTH_ADD: "false" | ||
| web: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add newline in between for better readability.
| PROXY_AUTH_ADD: "false" | |
| web: | |
| PROXY_AUTH_ADD: "false" | |
| web: |
Thanks a lot @al-lac for the review ⭐ Yes it is causing the same error for me, I'll dig into the issue and will push a fix. |
App Submission
App name (required)
fx
256x256 SVG icon (required)
Gallery images (required)
I have tested my app on (check at least one):