-
Notifications
You must be signed in to change notification settings - Fork 517
App Submission: Arcane #4017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
App Submission: Arcane #4017
Conversation
App Submission: LinkStack - Self-hosted open-source Linktree alternative
Mr-Sunglasses
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dennysubke 👋🏻 ,
Another really nice and handy app submission! 🏆
Great job on it, I only noticed a few small things that need to be adjusted.
I've tested it on my umbrel home and it is working seamlessly 🚀 .
|
| Severity | File | Description |
|---|---|---|
| ℹ️ | arcane/docker-compose.yml |
Potentially using unsafe user in service "docker": The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000. |
| ℹ️ | arcane/docker-compose.yml |
Service "docker" uses host network mode: The host network mode can lead to security vulnerabilities. If possible please use the default bridge network mode and expose the necessary ports. |
arcane/umbrel-app.yml |
"icon" and "gallery" needs to be empty for new app submissions: The "icon" and "gallery" fields must be empty for new app submissions as it is being created by the Umbrel team. |
Legend
| Symbol | Description |
|---|---|
| ❌ | Error: This must be resolved before this PR can be merged. |
| Warning: This is highly encouraged to be resolved, but is not strictly mandatory. | |
| ℹ️ | Info: This is just for your information. |
Hey @Mr-Sunglasses! 😎 I’ve made the changes you suggested. Thanks a lot for the review! 💪🏻 |
Mr-Sunglasses
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for making the changes @dennysubke 🥇
Lets prepare the gallery assets now 🎨
App Submission
Arcane
...
Icon
...
Gallery images
I have tested my app on: