✨ Filter out inbound rules added by external controllers, like the AWS LB controller, when reconciling worker node sg #640
+38
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LB controller, when reconciling worker node sg
iuriaranda
approved these changes
Nov 20, 2025
fiunchinho
changed the title
AndiDog
requested changes
Nov 21, 2025
|
|
||
| // Filter out rules managed by external controllers (e.g., AWS Load Balancer Controller) | ||
| // These rules should not be revoked by CAPA as they are managed by other components. | ||
| current := filterIgnoredIngressRules(sg.IngressRules) |
There was a problem hiding this comment.
The variable name now isn't descriptive of its content anymore. Let's please use re-assign with the new meaning, or rename:
Suggested change
| current := filterIgnoredIngressRules(sg.IngressRules) | |
| currentFiltered := filterIgnoredIngressRules(sg.IngressRules) |
But actually, I think the below comment is better for understanding the function flow...
| // Duplicate rules with multiple cidr blocks/source security groups so that we are comparing similar sets. | ||
| want := expandIngressRules(specRules) | ||
|
|
||
| toRevoke := current.Difference(want) |
There was a problem hiding this comment.
Instead of the above, I would like the filtering to be done here, since what we want to do is not delete those rules, and this is the code that does exactly that:
Suggested change
| // Do not revoke rules managed by external controllers (e.g., AWS Load Balancer Controller). | |
| toRevoke := filterIgnoredIngressRules(current.Difference(want)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards https://github.com/giantswarm/giantswarm/issues/34926