Skip to content

Conversation

@AndiDog
Copy link
Contributor

@AndiDog AndiDog commented Nov 20, 2025

What this PR does / why we need it

See giantswarm/schemadocs#159 – this PR contains the documentation generated with the new version of schemadocs. I've minified the needed JSON schema for the pool types in order to not create duplicates in documentation. For that purpose, I also added another Helm values test file to ensure all three values for $nodePool.type work fine (unset, machinepool, karpenter).

Checklist

  • Updated CHANGELOG.md.

Trigger E2E tests

Later, let's first get this reviewed to ensure the schema is still correct.

…ed), reduce redundant parts of JSON schema for Karpenter vs. MachinePool types of node pools
@AndiDog AndiDog requested a review from a team as a code owner November 20, 2025 17:54
@AndiDog AndiDog added this to Roadmap Nov 20, 2025
@AndiDog AndiDog moved this to Blocked / Waiting ⛔️ in Roadmap Nov 20, 2025
@github-actions
Copy link
Contributor

There were differences in the rendered Helm template, please check! ⚠️

Output
=== Differences when rendered with values file helm/cluster-aws/ci/test-auditd-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster-aws/ci/test-eni-mode-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster-aws/ci/test-hop-count-tuning-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster-aws/ci/test-irsa-crossplane-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster-aws/ci/test-karpenter-full-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster-aws/ci/test-karpenter-mixed-with-regular-nodepools-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster-aws/ci/test-karpenter-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster-aws/ci/test-lifecycle-hook-heartbeattimeout-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster-aws/ci/test-local-registry-cache-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster-aws/ci/test-machinehealthcheck-node-problem-detector-used-control-plane-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster-aws/ci/test-machinehealthcheck-node-problem-detector-used-workers-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster-aws/ci/test-machinepool-values.yaml ===
Diff error


=== Differences when rendered with values file helm/cluster-aws/ci/test-mc-proxy-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster-aws/ci/test-multiple-authenticated-mirrors-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster-aws/ci/test-multiple-service-account-issuers-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster-aws/ci/test-multiple-vpc-cidrs-eni-mode-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster-aws/ci/test-multiple-vpc-cidrs-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster-aws/ci/test-network-topology-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster-aws/ci/test-nodeport-cidrs-eni-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster-aws/ci/test-nodeport-cidrs-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster-aws/ci/test-non-default-vpc-cidr-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster-aws/ci/test-spot-instances-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster-aws/ci/test-subnet-tags-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster-aws/ci/test-vpc-id-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster-aws/ci/test-wc-minimal-values.yaml ===

No difference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Blocked / Waiting ⛔️

Development

Successfully merging this pull request may close these issues.

2 participants