Add missing documentation for node pools (health checks were not listed), reduce redundant parts of JSON schema for Karpenter vs. MachinePool types of node pools #1606
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
See giantswarm/schemadocs#159 – this PR contains the documentation generated with the new version of
schemadocs. I've minified the needed JSON schema for the pool types in order to not create duplicates in documentation. For that purpose, I also added another Helm values test file to ensure all three values for$nodePool.typework fine (unset,machinepool,karpenter).Checklist
Trigger E2E tests
Later, let's first get this reviewed to ensure the schema is still correct.