pcre2: update to 10.47 #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Ah, we're only running |
Member
|
@rimrul how about simply dropping building (and deploying) i686? we're not using the i686 MSYS package in MinGit... |
For some reason, PCRE2 v10.47 fails the test suite on i686. Since Git for Windows does not support i686 assets other than MinGit anymore (and i686 MinGit does not use the MSYS variant of the `pcre2` library), it is not actually needed. Signed-off-by: Johannes Schindelin <[email protected]>
Signed-off-by: Matthias Aßhauer <[email protected]>
Member
|
I will manually deploy it (x86_64-only). -> https://github.com/git-for-windows/git-for-windows-automation/actions/runs/19042556102 |
There is a test in PCRE2 that has given us grief for long enough when building the MSYS variant of PCRE2: The ISO-8859-1 one. The problem is a difference in assumptions between PCRE2 and the Cygwin runtime (or for that matter, the MSYS2 runtime). For years, we tried to work around it, but it is finally time to admit that keeping the workaround working is not worth the effort. All it would do would be to continually document the difference in opinion, and it would not add the confidence a test should add. So let's drop the workaround, and skip the ISO-8859-1 test at long last. Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes git-for-windows/git#5895