Skip to content

Conversation

@crimsonknave
Copy link
Collaborator

CI is pulling 3.14 now and it's causing CI to fail

Copilot AI review requested due to automatic review settings November 7, 2025 16:26
@crimsonknave crimsonknave requested a review from a team as a code owner November 7, 2025 16:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR pins the Python version used in the Pyright type checking workflow from the latest 3.x to a specific version 3.12.

  • Changed the Python version specification from '3.x' to '3.12' in the pyright.yaml workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

uses: actions/setup-python@v6
with:
python-version: '3.x'
python-version: '3.12'
Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The pytest workflow uses a matrix strategy to test against Python versions 3.9, 3.10, 3.11, 3.12, and 3.13, while the project supports Python >=3.6 (per pyproject.toml). Pinning pyright to only Python 3.12 means type checking won't catch type issues specific to other supported versions. Consider testing type checking against the minimum supported version (3.6 or 3.9) to ensure backward compatibility, or against multiple versions if version-specific type behaviors are a concern.

See below for a potential fix:

    strategy:
      matrix:
        python-version: [3.6, 3.9, 3.10, 3.11, 3.12, 3.13]
    steps:
    - uses: actions/checkout@v5
    - name: Set up Python
      uses: actions/setup-python@v6
      with:
        python-version: ${{ matrix.python-version }}

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants