fix: incorrect logic to create release packages #1137
+5
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When creating release packages with a subset of AGENTS or SCRIPTS, the logic was not working.
Solution
Fixed the incorrect logic in the release package creation script by:
norm_listfunction to properly handle comma-separated values and convert them to unique line-separated values (mapfilerequired)validate_subsetfunction to useinvalidvariable instead ofokfor better clarity and correct behaviorChanges
norm_listfunction to correctly convert comma+space separated values to line separated unique valuesvalidate_subsetfunction to useinvalidvariable instead ofokfor validation status$invalidinstead of$okExample
Testing script
Before (buggy behavior):
The script would not properly handle subset AGENTS or SCRIPTS when creating release packages due to incorrect parsing and validation logic.
After (correct behavior):
The script now correctly creates release packages with subset AGENTS or SCRIPTS by properly parsing the input and validating against allowed values.
Related
None