Skip to content

Conversation

@lshgdut
Copy link

@lshgdut lshgdut commented Nov 7, 2025

Problem

When creating release packages with a subset of AGENTS or SCRIPTS, the logic was not working.

Solution

Fixed the incorrect logic in the release package creation script by:

  1. Updating the norm_list function to properly handle comma-separated values and convert them to unique line-separated values (mapfile required)
  2. Correcting the return logic in validate_subset function to use invalid variable instead of ok for better clarity and correct behavior

Changes

  • Modified norm_list function to correctly convert comma+space separated values to line separated unique values
  • Updated validate_subset function to use invalid variable instead of ok for validation status
  • Changed return statement to use $invalid instead of $ok

Example

Testing script

AGENTS="copilot,gemini" SCRIPTS=sh .github/workflows/scripts/create-release-packages.sh v0.2.0

Before (buggy behavior):
The script would not properly handle subset AGENTS or SCRIPTS when creating release packages due to incorrect parsing and validation logic.

After (correct behavior):
The script now correctly creates release packages with subset AGENTS or SCRIPTS by properly parsing the input and validating against allowed values.

Related

None

@lshgdut lshgdut requested a review from localden as a code owner November 7, 2025 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant