Skip to content

Conversation

@BLumia
Copy link
Member

@BLumia BLumia commented Nov 20, 2025

This patch amends #27507.

Since #35072, selectable css class can be used for providing hover effect for tables. This patch let the wiki page be able to make use of that css class, and we can safely remove the custom css for this purpose.

Behavior is not changed.


Side note: I made this patch locally months ago but completely forget to submit it as a PR 😂

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 20, 2025
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/frontend labels Nov 20, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 20, 2025
@silverwind
Copy link
Member

I verified the existing rule .ui.selectable.table > tbody > tr:hover matches.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 20, 2025
@lunny lunny added this to the 1.26.0 milestone Nov 20, 2025
@silverwind silverwind enabled auto-merge (squash) November 20, 2025 21:11
@silverwind silverwind merged commit afc25c5 into go-gitea:main Nov 20, 2025
37 of 38 checks passed
@BLumia BLumia deleted the wiki-selectable branch November 21, 2025 01:53
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 22, 2025
* giteaofficial/main:
  Fix various permission & login related bugs (go-gitea#36002)
  Allow empty commit when merging pull request with squash style (go-gitea#35989)
  [skip ci] Updated translations via Crowdin
  Mention proc-receive in text for dashboard.resync_all_hooks func (go-gitea#35991)
  Update JS deps (go-gitea#35978)
  wiki: reuse selectable style for wiki (go-gitea#35990)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/templates This PR modifies the template files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants