Skip to content

Conversation

@KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Nov 13, 2025

Fixes #112549

I tried different solutions too, but I don't even know what is really happening.

@KoBeWi KoBeWi added this to the 4.6 milestone Nov 13, 2025
@KoBeWi KoBeWi requested a review from a team as a code owner November 13, 2025 19:44
@lodetrick
Copy link
Contributor

lodetrick commented Nov 15, 2025

When working on #112792, I think I found a solution to this, it is to change the early exit condition in _repaint to:

bool panel_collapsed = get_current_tab() == -1;
if (!panel_collapsed && (get_previous_tab() != -1)) {
    return;
}

This way, repaint will now be called when both current_tab and previous_tab are -1, which will only be the case on startup. It appears that _repaint wasn't actually executing on startup due to this condition, even though we wanted it to be executed.

@Repiteo
Copy link
Contributor

Repiteo commented Nov 17, 2025

Superseded by #112792

@Repiteo Repiteo closed this Nov 17, 2025
@Repiteo Repiteo removed this from the 4.6 milestone Nov 17, 2025
@KoBeWi KoBeWi deleted the maybe_we_should_just_make_everything_deferred_idk branch November 17, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bottom panel glitched when closed on startup

3 participants