feat: Add GitHub Enterprise App installation repository management APIs #3831
+290
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3831 +/- ##
==========================================
- Coverage 92.38% 91.79% -0.60%
==========================================
Files 196 197 +1
Lines 14094 17645 +3551
==========================================
+ Hits 13021 16197 +3176
- Misses 884 1259 +375
Partials 189 189 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Use EnterpriseService instead of creating new service - Add EnterpriseInstallationRepositoriesOptions for consistency - Update method signatures to Required
gmlewis
requested changes
Nov 17, 2025
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @nithish-95!
One minor tweak, please, then we should be ready to merge after a second LGTM+Approval from any other contributor to this repo.
cc: @stevehipwell - @alexandear - @zyfy29
| // GitHub API docs: https://docs.github.com/enterprise-cloud@latest/rest/enterprise-admin/organization-installations#toggle-installation-repository-access-between-selected-and-all-repositories | ||
| // | ||
| //meta:operation PATCH /enterprises/{enterprise}/apps/organizations/{org}/installations/{installation_id}/repositories | ||
| func (s *EnterpriseService) ToggleInstallationRepositories(ctx context.Context, enterprise, org string, installationID int64, opts *EnterpriseInstallationRepositoriesToggleOptions) (*ListRepositories, *Response, error) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| func (s *EnterpriseService) ToggleInstallationRepositories(ctx context.Context, enterprise, org string, installationID int64, opts *EnterpriseInstallationRepositoriesToggleOptions) (*ListRepositories, *Response, error) { | |
| func (s *EnterpriseService) ToggleInstallationRepositories(ctx context.Context, enterprise, org string, installationID int64, opts EnterpriseInstallationRepositoriesToggleOptions) (*ListRepositories, *Response, error) { |
Not-Dhananjay-Mishra
suggested changes
Nov 17, 2025
| // GitHub API docs: https://docs.github.com/enterprise-cloud@latest/rest/enterprise-admin/organization-installations#get-the-repositories-accessible-to-a-given-github-app-installation | ||
| // | ||
| //meta:operation GET /enterprises/{enterprise}/apps/organizations/{org}/installations/{installation_id}/repositories | ||
| func (s *EnterpriseService) ListRepositoriesForOrgInstallation(ctx context.Context, enterprise, org string, installationID int64, opts *ListOptions) (*ListRepositories, *Response, error) { |
Contributor
There was a problem hiding this comment.
This endpoint return this response
{
"type": "array",
"items": {
"title": "Accessible Repository",
"description": "A repository that may be made accessible to a GitHub App.",
"type": "object",
"properties": {
"id": {
"description": "Unique identifier of the repository",
"type": "integer",
"format": "int64",
"examples": [
1
]
},
"name": {
"description": "The name of the repository.",
"type": "string",
"examples": [
"Team Environment"
]
},
"full_name": {
"type": "string",
"examples": [
"octocat/Hello-World"
]
}
},
"required": [
"full_name",
"id",
"name"
]
}
}But the function currently returns ListRepositories, which has this struct:
type ListRepositories struct {
TotalCount *int `json:"total_count,omitempty"`
Repositories []*Repository `json:"repositories"`
}I made a struct named AccessibleRepository in PR #3830, you can re-use it and update this function to return []*AccessibleRepository once my PR is merged.
| // GitHub API docs: https://docs.github.com/enterprise-cloud@latest/rest/enterprise-admin/organization-installations#toggle-installation-repository-access-between-selected-and-all-repositories | ||
| // | ||
| //meta:operation PATCH /enterprises/{enterprise}/apps/organizations/{org}/installations/{installation_id}/repositories | ||
| func (s *EnterpriseService) ToggleInstallationRepositories(ctx context.Context, enterprise, org string, installationID int64, opts *EnterpriseInstallationRepositoriesToggleOptions) (*ListRepositories, *Response, error) { |
Contributor
There was a problem hiding this comment.
This endpoint does not return a schema similar to ListRepositories.
Suggested change
| func (s *EnterpriseService) ToggleInstallationRepositories(ctx context.Context, enterprise, org string, installationID int64, opts *EnterpriseInstallationRepositoriesToggleOptions) (*ListRepositories, *Response, error) { | |
| func (s *EnterpriseService) ToggleInstallationRepositories(ctx context.Context, enterprise, org string, installationID int64, opts *EnterpriseInstallationRepositoriesToggleOptions) (*Installation, *Response, error) { |
| // GitHub API docs: https://docs.github.com/enterprise-cloud@latest/rest/enterprise-admin/organization-installations#grant-repository-access-to-an-organization-installation | ||
| // | ||
| //meta:operation PATCH /enterprises/{enterprise}/apps/organizations/{org}/installations/{installation_id}/repositories/add | ||
| func (s *EnterpriseService) AddRepositoriesToInstallation(ctx context.Context, enterprise, org string, installationID int64, opts EnterpriseInstallationRepositoriesOptions) (*ListRepositories, *Response, error) { |
Contributor
There was a problem hiding this comment.
same here, it should return []*AccessibleRepository (the struct is in my PR, which hasn’t been merged yet).
| // GitHub API docs: https://docs.github.com/enterprise-cloud@latest/rest/enterprise-admin/organization-installations#remove-repository-access-from-an-organization-installation | ||
| // | ||
| //meta:operation PATCH /enterprises/{enterprise}/apps/organizations/{org}/installations/{installation_id}/repositories/remove | ||
| func (s *EnterpriseService) RemoveRepositoriesFromInstallation(ctx context.Context, enterprise, org string, installationID int64, opts EnterpriseInstallationRepositoriesOptions) (*ListRepositories, *Response, error) { |
Contributor
There was a problem hiding this comment.
same here, it should return []*AccessibleRepository (the struct is in my PR, which hasn’t been merged yet).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements enterprise GitHub App installation repository management endpoints for issue #3829.
This PR adds the following endpoints:
Changes
ListRepositoriesForOrgInstallationmethod to list repositories accessible to an app installationToggleInstallationRepositoriesmethod to update repository selectionAddRepositoriesToInstallationmethod to add repositories to an installationRemoveRepositoriesFromInstallationmethod to remove repositories from an installationTesting
cc @gmlewis @Not-Dhananjay-Mishra