Skip to content

Conversation

@mpeddada1
Copy link
Collaborator

@mpeddada1 mpeddada1 commented Nov 20, 2025

Command to run: DOCKER_NETWORK=host time ci/cloudbuild/build.sh -t conformance-pr

Add check for when column type is empty. Also move the check for empty resultsetmetadata to PrepareQuery (this is the desired location for returning the error).

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Nov 20, 2025
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 92.77108% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.95%. Comparing base (45fe5af) to head (b0bec0c).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...le/cloud/bigtable/internal/data_connection_impl.cc 80.00% 4 Missing ⚠️
...oud/bigtable/internal/data_connection_impl_test.cc 96.82% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #15787    +/-   ##
========================================
  Coverage   92.94%   92.95%            
========================================
  Files        2454     2454            
  Lines      226878   227020   +142     
========================================
+ Hits       210879   211024   +145     
+ Misses      15999    15996     -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mpeddada1 mpeddada1 marked this pull request as ready for review November 20, 2025 22:24
@mpeddada1 mpeddada1 requested a review from a team as a code owner November 20, 2025 22:24
@mpeddada1 mpeddada1 merged commit 81b496f into googleapis:main Nov 20, 2025
68 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants