-
Notifications
You must be signed in to change notification settings - Fork 9
Support .NET 10 #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support .NET 10 #219
Conversation
2ce2b16 to
5e1f32f
Compare
b4e81c1 to
48cee16
Compare
48cee16 to
7322c3e
Compare
7322c3e to
69eb80f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for .NET 10 by updating target frameworks and dependencies across the project structure. The changes prepare the codebase for testing with .NET 10 release candidate versions before the stable release in November.
Key changes:
- Updated target frameworks to include
net10.0across all project files - Migrated from .NET 8.0 to .NET 10.0 RC versions for SDK and package dependencies
- Restructured examples and Docker configurations to use .NET 10.0
Reviewed Changes
Copilot reviewed 13 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/Grafana.OpenTelemetry.Tests/Grafana.OpenTelemetry.Tests.csproj | Added net10.0 target framework alongside existing net8.0 |
| src/Grafana.OpenTelemetry/Grafana.OpenTelemetry.csproj | Added net10.0 as the first target framework |
| src/Grafana.OpenTelemetry.Base/Grafana.OpenTelemetry.Base.csproj | Added net10.0 target framework and conditional package reference updates |
| global.json | Updated .NET SDK version to 10.0.100-rc.1 |
| examples/net8.0/aspnetcore/Dockerfile | Removed .NET 8.0 Dockerfile |
| examples/net10.0/aspnetcore/aspnetcore.csproj | Updated target framework and Entity Framework package to net10.0/v10.0.0-rc.1 |
| examples/net10.0/aspnetcore/Dockerfile | Added new .NET 10.0 Dockerfile with RC images |
| docker/docker-compose-* | Updated Docker compose files to reference net10.0 example |
| GrafanaOpenTelemetry.slnx | Added new solution file with net10.0 example project |
| GrafanaOpenTelemetry.sln | Removed legacy solution file |
| .github/workflows/ci.yml | Added explicit .NET 8 SDK setup step |
Add support for .NET 10, using .NET 10 preview 6 initially.
- Install the .NET 8 SDK for testing. - Install the .NET SDK from `global.json` before running `dotnet format`.
Update to preview 7 of .NET 10.
Update to release candidate 1 of .NET 10.
69eb80f to
0284267
Compare
Update to release candidate 2 of .NET 10.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 13 out of 22 changed files in this pull request and generated 1 comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 14 out of 23 changed files in this pull request and generated no new comments.
src/Grafana.OpenTelemetry.Base/Grafana.OpenTelemetry.Base.csproj
Outdated
Show resolved
Hide resolved
Update to stable release of .NET 10.
Update to latest packages.
Restore with correct new name.
Update more OpenTelemetry NuGet packages to their latest versions.
Add further entries for new version bumps.
Update all OpenTelemetry NuGet packages to their latest versions.
Initial updates for 1.14.
Apply fixes for comments from Copilot.
Add remaining changes for 1.14.*.
Update to latest 1.14.* packages.
Update all NuGet packages to their latest versions.
|
Merged #273 into this PR, will rebase onto main once that's merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 15 out of 24 changed files in this pull request and generated 4 comments.
src/Grafana.OpenTelemetry.Base/Grafana.OpenTelemetry.Base.csproj
Outdated
Show resolved
Hide resolved
Fix incorrect condition to override System.Text.Json now that `net10.0` has been added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 14 out of 23 changed files in this pull request and generated no new comments.
Changes
Add support for .NET 10.
I think the easiest way to do it is to merge #273 once open-telemetry/opentelemetry-dotnet#6667 and open-telemetry/opentelemetry-dotnet-contrib#3403 are merged and released so we get the 1.14.* releases which havenet10.0targets, then rebase this and merge.Merge requirement checklist
CHANGELOG.mdupdatedChanges in public API reviewed (if applicable)