Skip to content

Conversation

@martincostello
Copy link
Member

@martincostello martincostello commented Aug 6, 2025

Changes

Add support for .NET 10.

I think the easiest way to do it is to merge #273 once open-telemetry/opentelemetry-dotnet#6667 and open-telemetry/opentelemetry-dotnet-contrib#3403 are merged and released so we get the 1.14.* releases which have net10.0 targets, then rebase this and merge.

Merge requirement checklist

  • Unit tests added/updated
  • CHANGELOG.md updated
  • Changes in public API reviewed (if applicable)

@martincostello martincostello added .NET Pull requests that update .NET code dependencies Pull requests that update a dependency file dockerfile Pull requests that update docker code labels Aug 6, 2025
Copilot AI review requested due to automatic review settings October 7, 2025 09:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for .NET 10 by updating target frameworks and dependencies across the project structure. The changes prepare the codebase for testing with .NET 10 release candidate versions before the stable release in November.

Key changes:

  • Updated target frameworks to include net10.0 across all project files
  • Migrated from .NET 8.0 to .NET 10.0 RC versions for SDK and package dependencies
  • Restructured examples and Docker configurations to use .NET 10.0

Reviewed Changes

Copilot reviewed 13 out of 22 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/Grafana.OpenTelemetry.Tests/Grafana.OpenTelemetry.Tests.csproj Added net10.0 target framework alongside existing net8.0
src/Grafana.OpenTelemetry/Grafana.OpenTelemetry.csproj Added net10.0 as the first target framework
src/Grafana.OpenTelemetry.Base/Grafana.OpenTelemetry.Base.csproj Added net10.0 target framework and conditional package reference updates
global.json Updated .NET SDK version to 10.0.100-rc.1
examples/net8.0/aspnetcore/Dockerfile Removed .NET 8.0 Dockerfile
examples/net10.0/aspnetcore/aspnetcore.csproj Updated target framework and Entity Framework package to net10.0/v10.0.0-rc.1
examples/net10.0/aspnetcore/Dockerfile Added new .NET 10.0 Dockerfile with RC images
docker/docker-compose-* Updated Docker compose files to reference net10.0 example
GrafanaOpenTelemetry.slnx Added new solution file with net10.0 example project
GrafanaOpenTelemetry.sln Removed legacy solution file
.github/workflows/ci.yml Added explicit .NET 8 SDK setup step

Add support for .NET 10, using .NET 10 preview 6 initially.
- Install the .NET 8 SDK for testing.
- Install the .NET SDK from `global.json` before running `dotnet format`.
Update to preview 7 of .NET 10.
Update to release candidate 1 of .NET 10.
Update to release candidate 2 of .NET 10.
Copilot AI review requested due to automatic review settings October 16, 2025 07:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 13 out of 22 changed files in this pull request and generated 1 comment.

Add workaround for regression in .NET 10 RC2 when multi-targeting with .NET Framework.
Remove condition.
Copilot AI review requested due to automatic review settings October 16, 2025 08:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 14 out of 23 changed files in this pull request and generated no new comments.

Update to stable release of .NET 10.
Update to latest packages.
Remove `server.address` for EFCore.
Restore with correct new name.
Update more OpenTelemetry NuGet packages to their latest versions.
Add further entries for new version bumps.
Update all OpenTelemetry NuGet packages to their latest versions.
Initial updates for 1.14.
Apply fixes for comments from Copilot.
Add remaining changes for 1.14.*.
Update to latest 1.14.* packages.
Update all NuGet packages to their latest versions.
Copilot AI review requested due to automatic review settings November 14, 2025 08:59
@martincostello
Copy link
Member Author

Merged #273 into this PR, will rebase onto main once that's merged.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 15 out of 24 changed files in this pull request and generated 4 comments.

Fix incorrect condition to override System.Text.Json now that `net10.0` has been added.
Copilot AI review requested due to automatic review settings November 14, 2025 15:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 14 out of 23 changed files in this pull request and generated no new comments.

@martincostello martincostello marked this pull request as ready for review November 14, 2025 15:56
@martincostello martincostello requested a review from a team as a code owner November 14, 2025 15:56
@martincostello martincostello merged commit b8b27ba into main Nov 14, 2025
26 checks passed
@martincostello martincostello deleted the dotnet-vnext branch November 14, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file dockerfile Pull requests that update docker code .NET Pull requests that update .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants