Chore: Add custom manager for workflow templates #2278
Closed
+19
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to 📬 Triage
in Plugins Platform / Grafana Community
Contributor
|
Hello! 👋 This repository uses Auto for releasing packages using PR labels. ✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs. |
grafana-plugins-platform-bot
bot
moved this from 📬 Triage
to 🔬 In review
in Plugins Platform / Grafana Community
sunker
added
the
no-changelog
jackw
reviewed
Nov 11, 2025
Co-authored-by: Jack Westbrook <[email protected]>
sunker
force-pushed
the
chore/workflow-templates-custom-manager
branch
from
1cb678a to
37f78e3
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses YAML parsing errors in Renovate by replacing the extended github-actions manager configuration with a custom regex manager for workflow templates that contain Handlebars syntax. The change enables Renovate to extract GitHub Actions dependencies from template files without attempting to parse them as valid YAML.
- Removed the
github-actionsmanager extension that was causing YAML parsing errors on Handlebars templates - Added a custom regex manager to extract GitHub Actions dependencies from workflow template files using pattern matching
- Created separate package rules for template workflows and repository workflows with distinct labels and reviewers
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Contributor
Author
|
Closing in favour of #2297 |
github-project-automation
bot
moved this from 🔬 In review
to 🚀 Shipped
in Plugins Platform / Grafana Community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
GitHub Actions workflow templates in
packages/create-plugin/templates/github/workflows/use Handlebars syntax, which causes the standardgithub-actionsmanager to fail with yaml parsing errors. We attempted to usemanagerFilePatternsto limit thegithub-actionsmanager scope, but this doesn't solve the underlying issue (the manager still tries to parse the templates as valid yaml).This PR adds a custom regex manager to extract gh action dependencies from the template files, and adds a separate package rule so workflow templates and repository workflows can have different labels.
I haven't been able to verify that this works, so for now I've disabled auto merging for both of these rules.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: