Skip to content

xds: Fix WRR test flake with TSAN #12523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ejona86 merged 1 commit into from
Dec 15, 2025
Merged

xds: Fix WRR test flake with TSAN #12523

ejona86 merged 1 commit into from
Dec 15, 2025
+3 −2

Conversation

@ejona86
Copy link
Member

@ejona86 ejona86 commented Nov 19, 2025

Fixes:

org.mockito.exceptions.verification.TooManyActualInvocations:
metricSink.addLongCounter(
    <custom argument matcher>,
    1L,
    [directaddress:///wrr-metrics],
    [, ]
);
Wanted 1 time:
-> at io.grpc.xds.WeightedRoundRobinLoadBalancerTest.metricWithRealChannel(WeightedRoundRobinLoadBalancerTest.java:1307)
But was 2 times:
-> at io.grpc.internal.MetricRecorderImpl.addLongCounter(MetricRecorderImpl.java:103)
-> at io.grpc.internal.MetricRecorderImpl.addLongCounter(MetricRecorderImpl.java:103)

	at io.grpc.xds.WeightedRoundRobinLoadBalancerTest.metricWithRealChannel(WeightedRoundRobinLoadBalancerTest.java:1307)

@ejona86
xds: Fix WRR test flake with TSAN
220475c 
Fixes:
```
org.mockito.exceptions.verification.TooManyActualInvocations:
metricSink.addLongCounter(
    <custom argument matcher>,
    1L,
    [directaddress:///wrr-metrics],
    [, ]
);
Wanted 1 time:
-> at io.grpc.xds.WeightedRoundRobinLoadBalancerTest.metricWithRealChannel(WeightedRoundRobinLoadBalancerTest.java:1307)
But was 2 times:
-> at io.grpc.internal.MetricRecorderImpl.addLongCounter(MetricRecorderImpl.java:103)
-> at io.grpc.internal.MetricRecorderImpl.addLongCounter(MetricRecorderImpl.java:103)

	at io.grpc.xds.WeightedRoundRobinLoadBalancerTest.metricWithRealChannel(WeightedRoundRobinLoadBalancerTest.java:1307)
```
@ejona86 ejona86 requested a review from AgraVator November 19, 2025 18:20
@ejona86
Copy link
Member Author

ejona86 commented Dec 3, 2025

@AgraVator, ping

@ejona86 ejona86 merged commit 24bd540 into grpc:master Dec 15, 2025
15 of 17 checks passed
@ejona86 ejona86 deleted the tsan-wrr branch December 15, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AgraVator AgraVator AgraVator approved these changes

+1 more reviewer

@sauravzg sauravzg sauravzg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ejona86 @AgraVator @sauravzg