-
-
Notifications
You must be signed in to change notification settings - Fork 114
Use collection types for return values #1447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Can you make a draft PR with the changes this causes in the generated code? |
|
What also might be worth considering here is parameters.
This might also be something to handle in a separate PR though. |
604ccc7 to
95ecf2c
Compare
|
Those should be handled in #1448 |
|
Looks good to me otherwise, if that wasn't clear. How should we proceed? :) |
|
Sorry for delay, I did some more testing and this is looking good for me too. But I think this situation should be resolved first: gtk-rs/gtk-rs-core#1078 |
Is there a better way to get the actual type of a C array from the builder? The best I could do is adding the
c_typelike this.I left the
Vec<OsString>andVec<PathBuf>return as is, since those require allocations and they are opt-in.