Remove L2A button AB test #14865
Merged
Remove L2A button AB test #14865
+10
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
vlbee
added
run_chromatic
github-actions
bot
removed
the
run_chromatic
Member
|
Hey Vanessa. The code changes look good but I wasn't able to test it locally before Emma took over DCAR CODE. If you could deploy this again tomorrow I'll do a quick test and confirm. |
Member
|
I've tested this on Android - it's working as expected. I get the with duration CTA every time irrespective of the value passed in AB test service. |
Member
Author
|
Waiting for iOS to clean up on their side before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Removes the AB test from the Listen To Article button introduced in #14343
Tested locally -> L2A in article button with audio duration appears on all articles (where audio files is available)