Skip to content

Conversation

@domlander
Copy link
Contributor

@domlander domlander commented Nov 18, 2025

What does this change?

Renames the LoopVideo and LoopVideoPlayer components to SelfHostedVideo and SelfHostedVideoPlayer.

Renames loop-video to self-hosted-video or video where appropriate.

Updating events sent to Ophan have not been amended in this PR.

Why?

We will soon be introducing cinemagraphs and non-looping videos to the fronts. These will reuse the components built to render looping video.

@domlander domlander self-assigned this Nov 18, 2025
@domlander domlander force-pushed the doml/rename-loop-video branch from 50837ba to 66de051 Compare November 18, 2025 14:23
@domlander domlander marked this pull request as ready for review November 18, 2025 14:23
@github-actions
Copy link

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@domlander domlander added run_chromatic Runs chromatic when label is applied fronts + curation maintenance Departmental tracking: maintenance work, not a fix or a feature labels Nov 18, 2025
@github-actions
Copy link

github-actions bot commented Nov 18, 2025

@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Nov 18, 2025
@domlander domlander force-pushed the doml/rename-loop-video branch from 66de051 to 5140ff7 Compare November 18, 2025 14:28
@domlander domlander added the run_chromatic Runs chromatic when label is applied label Nov 18, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Nov 18, 2025
@github-actions
Copy link

github-actions bot commented Nov 18, 2025

@domlander domlander requested a review from abeddow91 November 18, 2025 14:39
@domlander domlander force-pushed the doml/rename-loop-video branch from 5140ff7 to 57b710a Compare November 24, 2025 09:41
@domlander domlander added the run_chromatic Runs chromatic when label is applied label Nov 24, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Nov 24, 2025
@domlander domlander merged commit c44ee2c into main Nov 24, 2025
32 checks passed
@domlander domlander deleted the doml/rename-loop-video branch November 24, 2025 09:49
@gu-prout
Copy link

gu-prout bot commented Nov 24, 2025

Seen on PROD (merged by @domlander 8 minutes and 54 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dotcom-rendering fronts + curation maintenance Departmental tracking: maintenance work, not a fix or a feature Seen-on-PROD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants