-
Notifications
You must be signed in to change notification settings - Fork 30
Rename LoopVideo to SelfHostedVideo #14866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+116
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50837ba to
66de051
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
66de051 to
5140ff7
Compare
abeddow91
approved these changes
Nov 24, 2025
5140ff7 to
57b710a
Compare
|
Seen on PROD (merged by @domlander 8 minutes and 54 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dotcom-rendering
fronts + curation
maintenance
Departmental tracking: maintenance work, not a fix or a feature
Seen-on-PROD
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Renames the
LoopVideoandLoopVideoPlayercomponents toSelfHostedVideoandSelfHostedVideoPlayer.Renames
loop-videotoself-hosted-videoorvideowhere appropriate.Updating events sent to Ophan have not been amended in this PR.
Why?
We will soon be introducing cinemagraphs and non-looping videos to the fronts. These will reuse the components built to render looping video.