Skip to content

Conversation

@vlbee
Copy link
Member

@vlbee vlbee commented Nov 18, 2025

What does this change?

Adds a sound waveform as a background to Listen To Article button in articles rendered for app.
This PR make no other changes to the byline and meta designs.

Why?

Figma: https://www.figma.com/design/bIOvOoy1lz8b6X3wbDI1Z2/In-article-changes?node-id=5805-3607&t=nbPTs4WltsJMOsPp-4

Screenshots

Portrait:
image

Landscape:
image

Running Chromatic

In order to run Chromatic as part of the CI checks, you will need to add the run_chromatic label to your PR. Once the label is added Chromatic will run on every push.

Please only add this once you are ready to check for visual regressions, our intention here is to reduce the amount of time Chromatic is run without being looked at.
-->

@github-actions
Copy link

github-actions bot commented Nov 18, 2025

@vlbee vlbee changed the title WIP add audio waveform design to Listen To Article button Add audio waveform design to Listen To Article button Nov 19, 2025
@vlbee vlbee added run_chromatic Runs chromatic when label is applied feature Departmental tracking: work on a new feature labels Nov 19, 2025
@vlbee vlbee marked this pull request as ready for review November 19, 2025 10:25
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Nov 19, 2025
Copy link
Member

@arelra arelra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vlbee there's actually an existing 'fake' waveform component here:

export const WaveForm = ({
seed,
height,
bars,
progress = 0,
buffer = 0,
theme: userTheme,
gap = 1,
barWidth = 4,
...props
}: Props) => {

It was added in this PR: #12670

I wonder if we could reuse the existing implementation in DCAR rather than creating a new one?

@vlbee
Copy link
Member Author

vlbee commented Nov 19, 2025

Hi @vlbee there's actually an existing 'fake' waveform component here:

export const WaveForm = ({
seed,
height,
bars,
progress = 0,
buffer = 0,
theme: userTheme,
gap = 1,
barWidth = 4,
...props
}: Props) => {

It was added in this PR: #12670

I wonder if we could reuse the existing implementation in DCAR rather than creating a new one?

Thanks @arelra! This looks great. I was trying to mimic the iOS waveform implementation already in use on the apps for the podcast cards, so will show both options to the team. Agree the optimum solution would be to align on this element across platforms.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dotcom-rendering feature Departmental tracking: work on a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants