-
Notifications
You must be signed in to change notification settings - Fork 30
Add audio waveform design to Listen To Article button #14869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vlbee there's actually an existing 'fake' waveform component here:
dotcom-rendering/dotcom-rendering/src/components/WaveForm.tsx
Lines 98 to 108 in 4a086f6
| export const WaveForm = ({ | |
| seed, | |
| height, | |
| bars, | |
| progress = 0, | |
| buffer = 0, | |
| theme: userTheme, | |
| gap = 1, | |
| barWidth = 4, | |
| ...props | |
| }: Props) => { |
It was added in this PR: #12670
I wonder if we could reuse the existing implementation in DCAR rather than creating a new one?
Thanks @arelra! This looks great. I was trying to mimic the iOS waveform implementation already in use on the apps for the podcast cards, so will show both options to the team. Agree the optimum solution would be to align on this element across platforms.
|

What does this change?
Adds a sound waveform as a background to Listen To Article button in articles rendered for app.
This PR make no other changes to the byline and meta designs.
Why?
Figma: https://www.figma.com/design/bIOvOoy1lz8b6X3wbDI1Z2/In-article-changes?node-id=5805-3607&t=nbPTs4WltsJMOsPp-4
Screenshots
Portrait:

Landscape:

Running Chromatic
In order to run Chromatic as part of the CI checks, you will need to add the
run_chromaticlabel to your PR. Once the label is added Chromatic will run on every push.Please only add this once you are ready to check for visual regressions, our intention here is to reduce the amount of time Chromatic is run without being looked at.
-->