Dispatch custom events on marketing components #14875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnastasiiaBalenko
added
the
maintenance
AnastasiiaBalenko
force-pushed
the
ab-marketing-components-events
branch
from
72533ee to
4f12ac7
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
github-actions
bot
removed
the
run_chromatic
tomrf1
reviewed
Nov 20, 2025
| if (impressionSeen && !reportedImpressionSeen) { | ||
| void getAcquisitionsClient().epicSeen(); | ||
| setReportedImpressionSeen(true); | ||
| document.dispatchEvent( |
Member
There was a problem hiding this comment.
this file is specific to the mobile apps and so I think we can consider it out of scope for now.
tomrf1
approved these changes
Nov 21, 2025
Member
tomrf1
left a comment
tomrf1
left a comment
There was a problem hiding this comment.
👍
we tested in CODE by checking each of the affected components still loads
github-actions
bot
removed
the
run_chromatic
|
Seen on PROD (merged by @AnastasiiaBalenko 6 minutes and 56 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Ticket link
This PR adds customEvents dispatching to the next components:
Why?
From a discussion from commercial dev where different components / team tech aren’t aware of each other’s activity. I.e., when the pop-up sign in gate displays and is hidden.
Aim of this PR: fire the events on marketing components' activities for other teams (e.g., comm dev) to receive.
Screenshots
Gutter event
SignInGate events
Banner events
Epic event