Product Link Buttons - move setting the data-component upstream #14877
+9
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverabrahams
changed the title
oliverabrahams
changed the title
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
emma-imber
approved these changes
Nov 24, 2025
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
|
Seen on PROD (merged by @oliverabrahams 8 minutes and 15 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Moves the setting of the data component upstream to the cards.
For links rendered by the render element function (In body)
data-component='in-body-product-link'
data-link-name='product link button primary' | 'product link button tertiary'
For links rendered by the left-col-card
data-component='product-card-left-col'
data-link-name='product link button primary' | 'product link button tertiary'
For links rendered by the inline-product-card
data-component='product-card-type-inline' | 'product-card-type-inline-only'
data-link-name='product link button primary' | 'product link button tertiary'
For the product image links
data-component='product-card-type-inline' | 'product-card-type-inline-only' | 'product-card-left-col'
data-link-name='product image link'