Add new scrollable onwards container with new design #14894
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marjisound
changed the title
github-actions
bot
removed
the
run_chromatic
marjisound
force-pushed
the
gallery-secondary-onward-container
branch
from
f4723ef to
938b4a8
Compare
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
marjisound
force-pushed
the
gallery-secondary-onward-container
branch
2 times, most recently
from
2b9af5d to
464aa26
Compare
github-actions
bot
removed
the
run_chromatic
marjisound
changed the title
github-actions
bot
removed
the
run_chromatic
marjisound
force-pushed
the
gallery-secondary-onward-container
branch
from
d0ab9df to
a54742c
Compare
github-actions
bot
removed
the
run_chromatic
marjisound
force-pushed
the
gallery-secondary-onward-container
branch
from
01bc311 to
de1226c
Compare
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR adds a new component
ScrollableSmallOnwards. The purpose of this component is to be used for onwards contents. Currently as part of this PR, the new component is only used for Gallery articles onwards. But the future plan is to migrate all the rest of articles to use the new design for onwards contents.Note: Because the design of the cards for this new container are different from the cards used in the existing onwards containers, I had to introduce a new field in the
Cardcomponent:contextFormat?: ArticleFormat;. This field is used to distinguish between the new design of the onwards cards in gallery articles and the existing onwards cards which are used in all other articles. In the future when we apply this new design to the onwards contents of all articles, this new field (contextFormat) can be removed.Why?
This change is a re-design of the onwards container. Currently as part of this PR, the re-design is only applied for the Gallery onwards containers, but the future plan is to do this for all article.
Screenshots
This PR fixes #14313