-
Notifications
You must be signed in to change notification settings - Fork 30
Product carousel card - V1 #14946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
charleycampbell
wants to merge
13
commits into
main
Choose a base branch
from
filter/carousel-card
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+461
−1
Draft
Product carousel card - V1 #14946
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
7ff741c
Adding new product card for the Carousel:
charleycampbell b393942
- Adds optional Read More which will anchor to the product element o…
charleycampbell c9f6023
fixing linting errors which failed the build
charleycampbell b5a46fa
fixing style lint build
charleycampbell 31d208c
Update dotcom-rendering/src/components/ProductCarouselCard.tsx
charleycampbell 284ab52
Update dotcom-rendering/src/components/ProductCarouselCard.tsx
charleycampbell 3a93697
Update dotcom-rendering/src/components/ProductCarouselCard.tsx
charleycampbell 6f21e66
Update dotcom-rendering/src/components/ProductCarouselCard.tsx
charleycampbell 48c525a
Update dotcom-rendering/src/components/ProductCarouselCard.tsx
charleycampbell d73a85e
Update dotcom-rendering/src/components/ProductCarouselCard.tsx
charleycampbell 6d6ea3f
Update dotcom-rendering/src/components/ProductCarouselCard.tsx
charleycampbell 2bb58e9
adding dark mode colours to product card and added a couple of new pa…
charleycampbell e9ce400
Merge branch 'main' into filter/carousel-card
charleycampbell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
300 changes: 300 additions & 0 deletions
300
dotcom-rendering/src/components/ProductCarouselCard.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,300 @@ | ||
| import type { Meta, StoryObj } from '@storybook/react-webpack5'; | ||
| import { productImage } from '../../fixtures/manual/productImage'; | ||
| import { ArticleDesign, ArticleDisplay, Pillar } from '../lib/articleFormat'; | ||
| import type { ProductBlockElement } from '../types/content'; | ||
| import { ProductCarouselCard } from './ProductCarouselCard'; | ||
|
|
||
| const product = { | ||
| _type: 'model.dotcomrendering.pageElements.ProductBlockElement', | ||
| elementId: 'b1f6e8e2-3f3a-4f0c-8d1e-5f3e3e3e3e3e', | ||
| primaryHeadingHtml: 'Best Kettle overall', | ||
| secondaryHeadingHtml: 'Bosch Sky Kettle', | ||
| brandName: 'Bosch', | ||
| productName: 'Sky Kettle', | ||
| image: productImage, | ||
| displayType: 'InlineWithProductCard', | ||
| lowestPrice: '£39.99', | ||
| customAttributes: [ | ||
| { name: 'What we love', value: 'It pours well and looks great' }, | ||
| { | ||
| name: "What we don't love", | ||
| value: 'The handle feels a bit cheap compared to the rest of it', | ||
| }, | ||
| ], | ||
| productCtas: [ | ||
| { | ||
| url: 'https://www.johnlewis.com/bosch-twk7203gb-sky-variable-temperature-kettle-1-7l-black/p3228625', | ||
| text: '', | ||
| retailer: 'John Lewis', | ||
| price: '£45.99', | ||
| }, | ||
| { | ||
| url: 'https://www.amazon.co.uk/Bosch-TWK7203GB-Sky-Variable-Temperature/dp/B07Z8VQ2V6', | ||
| text: '', | ||
| retailer: 'Amazon', | ||
| price: '£39.99', | ||
| }, | ||
| ], | ||
| starRating: 'none-selected', | ||
| content: [ | ||
| { | ||
| displayCredit: true, | ||
| _type: 'model.dotcomrendering.pageElements.ImageBlockElement', | ||
| role: 'inline', | ||
| media: { | ||
| allImages: [ | ||
| { | ||
| index: 0, | ||
| fields: { | ||
| height: '3213', | ||
| width: '3213', | ||
| }, | ||
| mediaType: 'Image', | ||
| mimeType: 'image/jpeg', | ||
| url: 'https://media.guimcode.co.uk/bacede2d976c26d6a224ede074d5634a3f1d304f/0_0_3213_3213/3213.jpg', | ||
| }, | ||
| { | ||
| index: 1, | ||
| fields: { | ||
| isMaster: 'true', | ||
| height: '3213', | ||
| width: '3213', | ||
| }, | ||
| mediaType: 'Image', | ||
| mimeType: 'image/jpeg', | ||
| url: 'https://media.guimcode.co.uk/bacede2d976c26d6a224ede074d5634a3f1d304f/0_0_3213_3213/master/3213.jpg', | ||
| }, | ||
| { | ||
| index: 2, | ||
| fields: { | ||
| height: '2000', | ||
| width: '2000', | ||
| }, | ||
| mediaType: 'Image', | ||
| mimeType: 'image/jpeg', | ||
| url: 'https://media.guimcode.co.uk/bacede2d976c26d6a224ede074d5634a3f1d304f/0_0_3213_3213/2000.jpg', | ||
| }, | ||
| { | ||
| index: 3, | ||
| fields: { | ||
| height: '1000', | ||
| width: '1000', | ||
| }, | ||
| mediaType: 'Image', | ||
| mimeType: 'image/jpeg', | ||
| url: 'https://media.guimcode.co.uk/bacede2d976c26d6a224ede074d5634a3f1d304f/0_0_3213_3213/1000.jpg', | ||
| }, | ||
| { | ||
| index: 4, | ||
| fields: { | ||
| height: '500', | ||
| width: '500', | ||
| }, | ||
| mediaType: 'Image', | ||
| mimeType: 'image/jpeg', | ||
| url: 'https://media.guimcode.co.uk/bacede2d976c26d6a224ede074d5634a3f1d304f/0_0_3213_3213/500.jpg', | ||
| }, | ||
| { | ||
| index: 5, | ||
| fields: { | ||
| height: '140', | ||
| width: '140', | ||
| }, | ||
| mediaType: 'Image', | ||
| mimeType: 'image/jpeg', | ||
| url: 'https://media.guimcode.co.uk/bacede2d976c26d6a224ede074d5634a3f1d304f/0_0_3213_3213/140.jpg', | ||
| }, | ||
| ], | ||
| }, | ||
| elementId: '76686aa1-2e47-4616-b4ed-a88d0afe07ed', | ||
| imageSources: [ | ||
| { | ||
| weighting: 'inline', | ||
| srcSet: [ | ||
| { | ||
| src: 'https://media.guimcode.co.uk/bacede2d976c26d6a224ede074d5634a3f1d304f/0_0_3213_3213/master/3213.jpg', | ||
| width: 620, | ||
| }, | ||
| { | ||
| src: 'https://media.guimcode.co.uk/bacede2d976c26d6a224ede074d5634a3f1d304f/0_0_3213_3213/master/3213.jpg', | ||
| width: 1240, | ||
| }, | ||
| { | ||
| src: 'https://media.guimcode.co.uk/bacede2d976c26d6a224ede074d5634a3f1d304f/0_0_3213_3213/master/3213.jpg', | ||
| width: 605, | ||
| }, | ||
| { | ||
| src: 'https://media.guimcode.co.uk/bacede2d976c26d6a224ede074d5634a3f1d304f/0_0_3213_3213/master/3213.jpg', | ||
| width: 1210, | ||
| }, | ||
| { | ||
| src: 'https://media.guimcode.co.uk/bacede2d976c26d6a224ede074d5634a3f1d304f/0_0_3213_3213/master/3213.jpg', | ||
| width: 445, | ||
| }, | ||
| { | ||
| src: 'https://media.guimcode.co.uk/bacede2d976c26d6a224ede074d5634a3f1d304f/0_0_3213_3213/master/3213.jpg', | ||
| width: 890, | ||
| }, | ||
| ], | ||
| }, | ||
| { | ||
| weighting: 'thumbnail', | ||
| srcSet: [ | ||
| { | ||
| src: 'https://media.guimcode.co.uk/bacede2d976c26d6a224ede074d5634a3f1d304f/0_0_3213_3213/master/3213.jpg', | ||
| width: 140, | ||
| }, | ||
| { | ||
| src: 'https://media.guimcode.co.uk/bacede2d976c26d6a224ede074d5634a3f1d304f/0_0_3213_3213/master/3213.jpg', | ||
| width: 280, | ||
| }, | ||
| { | ||
| src: 'https://media.guimcode.co.uk/bacede2d976c26d6a224ede074d5634a3f1d304f/0_0_3213_3213/master/3213.jpg', | ||
| width: 120, | ||
| }, | ||
| { | ||
| src: 'https://media.guimcode.co.uk/bacede2d976c26d6a224ede074d5634a3f1d304f/0_0_3213_3213/master/3213.jpg', | ||
| width: 240, | ||
| }, | ||
| ], | ||
| }, | ||
| { | ||
| weighting: 'supporting', | ||
| srcSet: [ | ||
| { | ||
| src: 'https://media.guimcode.co.uk/bacede2d976c26d6a224ede074d5634a3f1d304f/0_0_3213_3213/master/3213.jpg', | ||
| width: 380, | ||
| }, | ||
| { | ||
| src: 'https://media.guimcode.co.uk/bacede2d976c26d6a224ede074d5634a3f1d304f/0_0_3213_3213/master/3213.jpg', | ||
| width: 760, | ||
| }, | ||
| { | ||
| src: 'https://media.guimcode.co.uk/bacede2d976c26d6a224ede074d5634a3f1d304f/0_0_3213_3213/master/3213.jpg', | ||
| width: 300, | ||
| }, | ||
| { | ||
| src: 'https://media.guimcode.co.uk/bacede2d976c26d6a224ede074d5634a3f1d304f/0_0_3213_3213/master/3213.jpg', | ||
| width: 600, | ||
| }, | ||
| { | ||
| src: 'https://media.guimcode.co.uk/bacede2d976c26d6a224ede074d5634a3f1d304f/0_0_3213_3213/master/3213.jpg', | ||
| width: 620, | ||
| }, | ||
| { | ||
| src: 'https://media.guimcode.co.uk/bacede2d976c26d6a224ede074d5634a3f1d304f/0_0_3213_3213/master/3213.jpg', | ||
| width: 1240, | ||
| }, | ||
| { | ||
| src: 'https://media.guimcode.co.uk/bacede2d976c26d6a224ede074d5634a3f1d304f/0_0_3213_3213/master/3213.jpg', | ||
| width: 605, | ||
| }, | ||
| { | ||
| src: 'https://media.guimcode.co.uk/bacede2d976c26d6a224ede074d5634a3f1d304f/0_0_3213_3213/master/3213.jpg', | ||
| width: 1210, | ||
| }, | ||
| { | ||
| src: 'https://media.guimcode.co.uk/bacede2d976c26d6a224ede074d5634a3f1d304f/0_0_3213_3213/master/3213.jpg', | ||
| width: 445, | ||
| }, | ||
| { | ||
| src: 'https://media.guimcode.co.uk/bacede2d976c26d6a224ede074d5634a3f1d304f/0_0_3213_3213/master/3213.jpg', | ||
| width: 890, | ||
| }, | ||
| ], | ||
| }, | ||
| ], | ||
| data: { | ||
| alt: 'Testing Bosch Sky Kettle', | ||
| credit: 'Photograph: Rachel Ogden/The Guardian', | ||
| }, | ||
| }, | ||
| { | ||
| _type: 'model.dotcomrendering.pageElements.LinkBlockElement', | ||
| url: 'https://www.johnlewis.com/bosch-twk7203gb-sky-variable-temperature-kettle-1-7l-black/p3228625', | ||
| label: '£79.99 at John Lewis', | ||
| linkType: 'ProductButton', | ||
| }, | ||
| { | ||
| _type: 'model.dotcomrendering.pageElements.LinkBlockElement', | ||
| url: 'https://www.amazon.co.uk/Bosch-TWK7203GB-Sky-Variable-Temperature/dp/B07Z8VQ2V6', | ||
| label: '£79.99 at Amazon', | ||
| linkType: 'ProductButton', | ||
| }, | ||
| { | ||
| _type: 'model.dotcomrendering.pageElements.TextBlockElement', | ||
| html: '<p>Offering variable temperatures and a double-walled stainless-steel housing, the 3kW Sky is a brilliant blend of robust form and function. It boasts a low minimum boil (300ml), a keep-warm setting and touch controls.</p>', | ||
| elementId: '4a27eb68-6a03-4e82-a7d0-e4f1ef3ccb6f', | ||
| }, | ||
| { | ||
| _type: 'model.dotcomrendering.pageElements.TextBlockElement', | ||
| html: '<p><strong>Why we love it<br></strong>I found it difficult to select a best kettle from so many that performed well, but the Bosch Sky clinched it because it’s such a good all-rounder that will suit most people. It pours well, has a button that’s within easy reach of the handle so it’s simple to open the lid without touching it, and it’s insulated so the exterior doesn’t become too hot to touch. From a design perspective, it has a more industrial feel than many others – no frippery here – but not too modern that it wouldn’t fit into most kitchens. Its display is thoughtfully designed, easy to keep clean and lights up as it heats.</p>', | ||
| elementId: 'f48f03d4-bece-4763-874b-4027a311643e', | ||
| }, | ||
| { | ||
| _type: 'model.dotcomrendering.pageElements.TextBlockElement', | ||
| html: '<p>The exterior doesn’t get too hot (up to 40C), and while it wasn’t the fastest to boil in testing, it was only seconds behind the Dualit below. It clicked off at boiling point, and the water was still a toasty 78C 30 minutes later. At the hour point, it was 66C, and two hours 52C, meaning you’ll spend less time and energy reboiling.</p>', | ||
| elementId: 'df571922-33b1-416a-8b3d-ee756b638cc1', | ||
| }, | ||
| { | ||
| _type: 'model.dotcomrendering.pageElements.TextBlockElement', | ||
| html: '<p><strong>It’s a shame that … </strong> its premium look ends at the handle, which seems cheap and plasticky next to the sleek aesthetic of the rest of it.</p>', | ||
| elementId: 'd98fc724-8908-46e2-acc6-4739ad4d5719', | ||
| }, | ||
| ], | ||
| } satisfies ProductBlockElement; | ||
|
|
||
| const meta = { | ||
| component: ProductCarouselCard, | ||
| title: 'Components/ProductCarouselCard', | ||
| args: { | ||
| product, | ||
| format: { | ||
| design: ArticleDesign.Standard, | ||
| display: ArticleDisplay.Standard, | ||
| theme: Pillar.Lifestyle, | ||
| }, | ||
| showReadMore: true, | ||
| }, | ||
charleycampbell marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } satisfies Meta<typeof ProductCarouselCard>; | ||
|
|
||
| export default meta; | ||
|
|
||
| type Story = StoryObj<typeof meta>; | ||
|
|
||
| export const Default = {} satisfies Story; | ||
|
|
||
| export const WithoutReadMore = { | ||
| args: { | ||
| showReadMore: false, | ||
| }, | ||
| } satisfies Story; | ||
|
|
||
| export const WithoutHeadingDisclaimerOrReadMore = { | ||
| args: { | ||
| product: { | ||
| ...product, | ||
| primaryHeadingHtml: '', | ||
| }, | ||
| showReadMore: false, | ||
| }, | ||
| } satisfies Story; | ||
|
|
||
| export const WithLongHeadingProductNameAndCTA = { | ||
| args: { | ||
| product: { | ||
| ...product, | ||
| primaryHeadingHtml: 'Super long product category review name', | ||
| productName: | ||
| 'Sky Kettle with a super duper long name that goes on and on', | ||
| productCtas: [ | ||
| { | ||
| url: 'https://www.johnlewis.com/bosch-twk7203gb-sky-variable-temperature-kettle-1-7l-black/p3228625', | ||
| text: '', | ||
| retailer: 'John Lewis with a very long name', | ||
| price: '£45.99', | ||
| }, | ||
| ], | ||
| }, | ||
| }, | ||
| }; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added this here as I think it would be good to re-use this button component but happy to have a discussion offline if we think there is another appraoch
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should catch up with Alex H about this because the designs were put together before some of our chats about the CTA wording. It might be that this should now be aligned with the product cards and that we don't need this override? I will send a message over to check with him