Add assets endpoint to retrieve dcar assets #28368
Open
+43
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marjisound
force-pushed
the
add-app-assets-endpoint
branch
2 times, most recently
from
29922c9 to
834f25d
Compare
Co-authored-by: Jamie B <[email protected]>
marjisound
force-pushed
the
add-app-assets-endpoint
branch
4 times, most recently
from
fe10246 to
6a1375d
Compare
marjisound
force-pushed
the
add-app-assets-endpoint
branch
from
6a1375d to
9be7ddb
Compare
marjisound
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work was done in close collaboration with @arelra and @JamieB-gu , who contributed ideas and helped me in testing in the iOS app.
What does this change?
This PR adds a new endpoint
/dcar-assets/rendered-items-assetsin the frontend applications service. This endpoint gets the DCAR assets through Article rendering/assets/rendered-items-assetsendpoint.DCAR PR for this: guardian/dotcom-rendering#14816
Why
iOS app needs the assets that are included in the page returned by this endpoint, in order to store them in cache and use them for offline reading.
Test
Tested in CODE
Fixes part of #8938