A/B Update #556
Draft
A/B Update #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwsbck
force-pushed
the
a_b_update
branch
6 times, most recently
from
8260275 to
7a405bf
Compare
quitschbo
requested changes
Nov 14, 2025
daemon/Makefile
Outdated
| endif | ||
|
|
||
| ifeq ($(A_B_UPDATE),y) | ||
| SRC_CMODULES += \ |
Member
There was a problem hiding this comment.
add this to SRC_FILES, this is not a c_* module
daemon/a_b_update.c
Outdated
|
|
||
| IF_FALSE_GOTO(file_exists("/boot/EFI/BOOT/GYROIDOS.EFI.A"), out); | ||
| IF_FALSE_GOTO(file_exists("/boot/EFI/BOOT/GYROIDOS.EFI.B"), out); | ||
| IF_FALSE_GOTO(file_exists("/data/cml/device.conf.A"), out); |
Member
There was a problem hiding this comment.
use DEFAULT_CONF_BASE_PATH (defined in cmld.h) instead of using "/data/cml/"
common/efivars.c
Outdated
| const char *const argv_clear_boot_0001[] = { "efibootmgr", "-b", "1", "-B", NULL }; | ||
| // efibootmgr --create --disk /dev/sda --part 1 --label 'Gyroidos0000' --loader \\EFI\\BOOT\\gyroidos.efi.0000 | ||
| const char *const argv_set_boot_0000[] = { "efibootmgr", "--create-only", | ||
| "--disk", "/dev/sda", |
Member
There was a problem hiding this comment.
We have to get this dynamically, e.g., by udevd generated by-label
jwsbck
force-pushed
the
a_b_update
branch
2 times, most recently
from
e580867 to
c0bb3ed
Compare
Signed-off-by: Johannes Wiesböck <[email protected]>
Signed-off-by: Johannes Wiesböck <[email protected]>
quitschbo
reviewed
Dec 1, 2025
daemon/a_b_update.c
Outdated
| } | ||
|
|
||
| /*****************************************************************************/ | ||
| /* EFI specific functions */ |
Member
There was a problem hiding this comment.
We should put this in an own c file which is added in the Makefile if A_B_UPDATE_BACKEND is set to 'y'.
Also all a_b_update files should then go into a sub dir like we have for seccomp
jwsbck
force-pushed
the
a_b_update
branch
5 times, most recently
from
b53eeb9 to
1f30791
Compare
These provide generic functionality s.t. a similar mechanism can also be implemented on systems that do not have UEFI boot options. Signed-off-by: Johannes Wiesböck <[email protected]>
Signed-off-by: Johannes Wiesböck <[email protected]>
verify_flash_mount_entry() will check if the guestos is the kernel update and, if so, configure A/B update paths for flashed images. After flash the A/B update mechanism is instucted to boot into the new kernel once at the next reboot. Signed-off-by: Johannes Wiesböck <[email protected]>
Instead of using the plain device.conf path, calculate the path for the current boot option (device.conf.A or device.conf.B) using the A/B update mechanism. Signed-off-by: Johannes Wiesböck <[email protected]>
Signed-off-by: Johannes Wiesböck <[email protected]>
On every start, run the check routine to find whether A/B update is completely set up. This will automatically migrate classical installations to the redundant setup, when started for the first time. Signed-off-by: Johannes Wiesböck <[email protected]>
A/B update requires keeping more than only the latest version of the kernel guestos in the guestos store. Usually (if everything works fine) these are the last two versions, however, this may change if an update was not successful and was rolled back to the previous version. Then the 'oldold' version on the backup must be kept. Add an additional check that keeps a guestos if one of the redundant mount options points corresponds to the kernel image of the guestos. Signed-off-by: Johannes Wiesböck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.