Fix wrong return to prevent infinity loop #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Seems to be valid, but no time for testing |
Author
|
Without this change using specific PDF files the code enter on a infinity loop. Don't is possible test with any PDF files. I tested and worked fine for me. |
|
Hi, Can we close this? |
|
Without merge ? |
Collaborator
|
you asked for closing it. |
|
My mistake, I was asking to merge and finish this PR to close the subject |
Collaborator
|
Have no test for it, feel unsure about mergin it. Can you provide an example file, which ends up in an infinite loop? |
1 similar comment
Collaborator
|
Have no test for it, feel unsure about mergin it. Can you provide an example file, which ends up in an infinite loop? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.