enable the test profile in unit tests #882
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 856 renamed the test property file from application.yaml to application-test.yaml , which inadvertently caused it to no longer be loaded in unit/integration tests.
see: #856
This PR adds
@ActiveProfiles('test')to all existing tests to re-enable it.This isn't strictly needed- as the tests were passing without the property file loaded, but I think it makes the project more flexible, especially for forks that may add additional functionality and need to override or add properties.
For example, forks that add springboot-security to the classpath will cause spring to autoconfigure security settings that break the existing tests. Having the application-test properties in place and loaded would allow those forks to disable this autoconfiguration on the existing tests.