Inprove FhirTerser.visit and date searches #7415
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Formatting check succeeded! |
jmarchionatto
approved these changes
Nov 28, 2025
Collaborator
jmarchionatto
left a comment
jmarchionatto
left a comment
There was a problem hiding this comment.
Approved with a few comments
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/search/SearchCoordinatorSvcImpl.java
Show resolved
Hide resolved
...fhir-jpaserver-test-r4/src/test/java/ca/uhn/fhir/jpa/provider/r4/ResourceProviderR4Test.java
Show resolved
Hide resolved
...hir-server/src/main/java/ca/uhn/fhir/rest/server/interceptor/consent/ConsentInterceptor.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses several issues:
visitExtensionmethod which is only called for DSTU2 extensions. This method has been deprecated sincevisitcovers both.Patient?birthdate=2020-01-01) as a range with the same lower and upper bound, which causes an assertion banning duplicate parameters to fail when performing this search with assertions enabled (this bug does not affect correctness of results when assertions are not enabled)