Correct type for state object #4550
Merged
+2
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damusix
approved these changes
Aug 1, 2025
Contributor
damusix
left a comment
damusix
left a comment
There was a problem hiding this comment.
This seems correct @Marsup @kanongil
https://github.com/hapijs/statehood/blob/master/lib/index.d.ts#L8
kanongil
approved these changes
Aug 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type for the
statefield of theServerOptionsobject was qualified with aTODOthat questioned if the type should be the fullServerStateCookieOptionsor just those fields defined in the default value. Given the documentation (and validated by actual usage), the correct type is indeed the one the TODO presumed.This PR replaces the ad-hoc type with the proper already-existing type, and gets rid of the TODO.
This change is intrinsically safe as the type is an strict superset of the one being in use today, with all extra fields being optional.