MINOR: Generate-certificates and ca-sign-file options support #744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbromber
force-pushed
the
generate_certificates_signer
branch
from
1c93947 to
aa18dd9
Compare
pbromber
changed the title
pbromber
force-pushed
the
generate_certificates_signer
branch
from
aa18dd9 to
7be8976
Compare
pbromber
force-pushed
the
generate_certificates_signer
branch
from
7be8976 to
0ccc17f
Compare
pbromber
changed the title
pbromber
force-pushed
the
generate_certificates_signer
branch
from
0ccc17f to
0011cf4
Compare
oktalz
reviewed
Dec 1, 2025
documentation/doc.yaml
Outdated
| - Name of Kubernetes secret in format namespace/secret-name | ||
| applies_to: | ||
| - configmap | ||
| version_min: "1.11" |
Member
There was a problem hiding this comment.
can you put
version_min: "3.2"
to be more accurate (this will end up in next version that should be released soon)
Contributor
Author
There was a problem hiding this comment.
Sure. Already changed this.
generate-certificates-signer option is used to configure haproxy generate-certificates and ca-sign-file bind options in ssl frontend.
pbromber
force-pushed
the
generate_certificates_signer
branch
from
0011cf4 to
8dc6f1b
Compare
Member
|
internal testing was green, one day I should take a look more closely why tests randomly fails on github. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces
generate-certificates-signerannotation, enabling kubernetes-ingress to automatically generate TLS certificates signed by a provided CA secret for incoming connections. This utilises generate-certificates and ca-sign-file haproxy bind options