Merge the nice work from Alexander Guz back into master #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… next version of PHPUnit there will be none)
Virtual file system with a Closure as a callback
…stringValue/AbstractBlock::renderAll This way complex objects could be passed between templates and to filters.
Context: defer object-to-string conversion
More tests
… coding standard We can't have both braces on the next line after classes, and on the same for functions. If we only would have to change braces by classes, that would be least possible change in terms of lines changed.
Adopt PHP-CS-Fixer
…n everything except padding
Update PHP Coding Standards Fixer, bump PHP version support
Co-authored-by: pavlikovsky <[email protected]>
* Fix: htmlentities(): Passing null to parameter 1 ($string) of type string is deprecated
* Create dependabot.yml This file is used to automate the process of keeping the GitHub Actions dependencies up to date by configuring Dependabot to check for updates on a weekly basis and apply them as needed. * Update .github/dependabot.yml --------- Co-authored-by: Alexey Kopytko <[email protected]>
Co-authored-by: Graham Campbell <[email protected]> Co-authored-by: Graham Campbell <[email protected]>
Bring the array syntax up to speed
* Improve performance I have identified three main bottlenecks when profiling the code with xdebug: 1. `array_shift()`: The array of tokens ended up being renumbered on each iteration. So we instead set consumed tokens to `null`. 2. `mb_substr()`: Using mutltibyte here is unnecessary and overkill, when we can just operate directly on the string. 3. `Liquid::get()`: This one surprised me, but due to the number of calls, here it is. Shave off more processing time by accessing the config array directly. Co-authored-by: Alexey Kopytko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.