Skip to content

Conversation

@frenck
Copy link
Member

@frenck frenck commented Nov 7, 2025

Proposed Changes

Fixes an warning raised by the Supervisor

Summary by CodeRabbit

  • Chores
    • Removed CodeNotary configuration settings from the build and application configuration.

@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementors. label Nov 7, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 7, 2025

Walkthrough

This pull request removes codenotary-related configuration entries from two YAML files in the adguard directory. Both the build configuration block and the public configuration key are deleted, eliminating codenotary dependencies from the deployment setup.

Changes

Cohort / File(s) Change Summary
Codenotary configuration removal
adguard/build.yaml, adguard/config.yaml
Removed codenotary configuration block (base_image and signer) from build.yaml and removed public configuration key codenotary: [email protected] from config.yaml

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Simple configuration deletion with no logic changes
  • Consistent pattern applied uniformly across two files
  • Minimal scope affecting only YAML configuration

Poem

🐰 A notary once signed our builds so bright,
But now we bid codenotary goodbye tonight!
Configuration cleared, the path runs lean,
Simplest deployments we've ever seen! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: removing deprecated codenotary fields from both build.yaml and config.yaml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch frenck-2025-0421

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 957ada4 and d3e7ea8.

📒 Files selected for processing (2)
  • adguard/build.yaml (0 hunks)
  • adguard/config.yaml (0 hunks)
💤 Files with no reviewable changes (2)
  • adguard/build.yaml
  • adguard/config.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@frenck frenck merged commit b812620 into main Nov 7, 2025
20 checks passed
@frenck frenck deleted the frenck-2025-0421 branch November 7, 2025 10:04
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix Inconsistencies or issues which will cause a problem for users or implementors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants