Access option for RSA keypair in Keychain #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orelli/Heimdall into colinmorelli-feature/add-accessibility # Conflicts: # Heimdall/Heimdall.swift
Renamed the access related code, to reduce confusion with accessibility related features in iOS/Keychain. Also, made sure the access related code is appropriately used (for example, there is no real need to store the value, as it is not used at all).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly refactored PR from #43. @colinmorelli, if possible, please review this. My main concern is the fact that the access flag can not be changed once set without regenerating the key. If this is a problem, then it needs to be addressed (for example, someone wanting to change the access as part of some switch in the app, without revoking the keypair).