Skip to content

Conversation

@Nana-EC
Copy link
Contributor

@Nana-EC Nana-EC commented Nov 21, 2025

Reviewer Notes

Related Issue(s)

Use keywords Fix, Fixes, Fixed, Close, Closes, Closed, Resolve, Resolves, Resolved
to connect an issue to be closed by this pull request.

@Nana-EC Nana-EC added this to the 0.24.0 milestone Nov 21, 2025
@Nana-EC Nana-EC self-assigned this Nov 21, 2025
@Nana-EC Nana-EC added the Block Node Issues/PR related to the Block Node. label Nov 21, 2025
@Nana-EC
Copy link
Contributor Author

Nana-EC commented Nov 22, 2025

Leaving in draft until @AlfredoG87 's PR #1891 goes in.
I can more easily rebase my PR to add some tests and other support I found useful here.
More important for verification logic to go in sooner

@Nana-EC Nana-EC force-pushed the 1880-bump-0-68-1-cn-proto branch from c4b9e3e to e8360d1 Compare November 29, 2025 04:54
@Nana-EC Nana-EC changed the title chore: Bump CN Proto 0.68.1 w Basic Footer Support chore: Improvements to Block Footer and Proof Support Nov 29, 2025
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
@codecov
Copy link

codecov bot commented Nov 29, 2025

Codecov Report

❌ Patch coverage is 38.88889% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...cation/session/impl/ExtendedMerkleTreeSession.java 38.88% 8 Missing and 3 partials ⚠️

❌ Your patch check has failed because the patch coverage (38.88%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

@@             Coverage Diff              @@
##               main    #1891      +/-   ##
============================================
- Coverage     79.48%   78.91%   -0.58%     
- Complexity     1193     1200       +7     
============================================
  Files           128      130       +2     
  Lines          5684     5781      +97     
  Branches        610      618       +8     
============================================
+ Hits           4518     4562      +44     
- Misses          887      934      +47     
- Partials        279      285       +6     
Files with missing lines Coverage Δ Complexity Δ
...cation/session/impl/ExtendedMerkleTreeSession.java 71.18% <38.88%> (-15.49%) 15.00 <0.00> (+13.00) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Block Node Issues/PR related to the Block Node.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants