docs: Updated protocol definition for publishers with new changes #1907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsync-swirlds
force-pushed
the
update-publisher-protocol
branch
2 times, most recently
from
e01ccfb to
0e2023b
Compare
* Changed `EndOfStream(BEHIND)` to `BehindPublisher` so we do not disconnect immediately
* This allows a Publisher to immediately catch up a block node that is only slightly "behind".
* Changed many `BlockProof` references to `BlockEnd` to reflect that blocks need an
explicit end of block because they may have multiple block proofs.
* Cleaned up a few other protocol issues
* Updated the API definition with the changes for `BehindPublisher`.
* Updated the node service API with the start of a new "server status details" API.
* Updated a distressing array of test classes, mostly due to tests that basically
cross-checked the _compiler_, not our design.
Signed-off-by: Joseph S. <[email protected]>
jsync-swirlds
force-pushed
the
update-publisher-protocol
branch
from
0e2023b to
7c58c05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer Notes
EndOfStream(BEHIND)toBehindPublisherso we do not disconnect immediatelyBlockProofreferences toBlockEndto reflect that blocks need an explicit end of block because they may have multiple block proofs.BehindPublisher.Fixes #1914
Important Note
Spotless is demanding changes to the markdown that break the markdown formatting, so that has to be overridden somehow...