Skip to content

Conversation

@AlfredoG87
Copy link
Contributor

adding timeout for both threads and latches so test can fail/timeout faster instead of having to wait 30mins for the CI runner to cancel it.

Improved some tests to make it less likely to stall

…faster instead of having to wait 30mins for the CI runner to cancel it.

Improved some tests to make it less likely to fail

Signed-off-by: Alfredo Gutierrez Grajeda <[email protected]>
@AlfredoG87 AlfredoG87 self-assigned this Nov 27, 2025
@AlfredoG87 AlfredoG87 added Bug A error that causes the feature to behave differently than what was expected based on design docs Tests issue related to enhancing the tests and removed Bug A error that causes the feature to behave differently than what was expected based on design docs labels Nov 27, 2025
@AlfredoG87 AlfredoG87 added this to the 0.24.0 milestone Nov 27, 2025
…rom other jobs

Signed-off-by: Alfredo Gutierrez Grajeda <[email protected]>
@Nana-EC
Copy link
Contributor

Nana-EC commented Nov 29, 2025

Good idea.
Odd, the 2 tests that consistently fail are because they are waiting on the onComplete latch due to a duplicate block.
What's odd is the BN registers and handles the duplicate case fine but for some reason the latch countdown doesn't occur.
Can't reproduce locally but will see what other options we have

Signed-off-by: Nana Essilfie-Conduah <[email protected]>
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
@Nana-EC Nana-EC self-assigned this Nov 30, 2025
@AlfredoG87 AlfredoG87 marked this pull request as ready for review December 1, 2025 14:58
@AlfredoG87 AlfredoG87 requested review from a team as code owners December 1, 2025 14:58
@AlfredoG87 AlfredoG87 merged commit 6416978 into main Dec 2, 2025
24 of 25 checks passed
@AlfredoG87 AlfredoG87 deleted the fix-api-tests branch December 2, 2025 02:05
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../block/node/stream/publisher/PublisherHandler.java 33.33% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (33.33%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

@@             Coverage Diff              @@
##               main    #1912      +/-   ##
============================================
- Coverage     79.48%   79.01%   -0.48%     
- Complexity     1193     1200       +7     
============================================
  Files           128      130       +2     
  Lines          5684     5770      +86     
  Branches        610      615       +5     
============================================
+ Hits           4518     4559      +41     
- Misses          887      930      +43     
- Partials        279      281       +2     
Files with missing lines Coverage Δ Complexity Δ
.../block/node/stream/publisher/PublisherHandler.java 88.50% <33.33%> (-0.28%) 56.00 <0.00> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tests issue related to enhancing the tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants