Skip to content

Conversation

@jasuwienas
Copy link
Contributor

@jasuwienas jasuwienas commented Dec 1, 2025

Description

Making some of the tests that fail during GitHub Actions runs more stable, focusing on those whose failure messages don’t clearly indicate whether the cause is nondeterministic:

  1. A test which fails because the block hasn’t been mined yet.
  2. A test which fails because it wasn’t executed with the expected price limits.

Related issue(s)

Fixes #4658

Testing Guide

  1. Run tests in GH action

Changes from original design (optional)

N/A

Additional work needed (optional)

N/A

Checklist

  • I've assigned an assignee to this PR and related issue(s) (if applicable)
  • I've assigned a label to this PR and related issue(s) (if applicable)
  • I've assigned a milestone to this PR and related issue(s) (if applicable)
  • I've updated documentation (code comments, README, etc. if applicable)
  • I've done sufficient testing (unit, integration, etc.)

@quiet-node quiet-node added the internal For changes that affect the project's internal workings but not its outward-facing functionality. label Dec 1, 2025
@quiet-node quiet-node modified the milestones: 0.73, 0.74.0 Dec 1, 2025
@jasuwienas jasuwienas marked this pull request as ready for review December 2, 2025 14:27
@jasuwienas jasuwienas requested review from a team as code owners December 2, 2025 14:27
@jasuwienas jasuwienas requested a review from natanasow December 2, 2025 14:27
Copy link
Contributor

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal For changes that affect the project's internal workings but not its outward-facing functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reducing number of randomly failing github actions - proposal - batch1 cache/hbar limiter large contract

3 participants