Skip to content

Conversation

@joostlek
Copy link
Member

@joostlek joostlek commented Nov 18, 2025

Proposed change

Bump pySmartThings to 3.3.4: pySmartThings/pysmartthings@v3.3.3...v3.3.4

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@joostlek joostlek added this to the 2025.11.3 milestone Nov 18, 2025
Copilot AI review requested due to automatic review settings November 18, 2025 19:20
Copilot finished reviewing on behalf of joostlek November 18, 2025 19:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the pySmartThings dependency from version 3.3.3 to 3.3.4 for the SmartThings integration, categorized as a bugfix.

  • Updates pySmartThings library version across all dependency files
  • Maintains consistent version pinning at 3.3.4

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
requirements_test_all.txt Updates pysmartthings test dependency to 3.3.4
requirements_all.txt Updates pysmartthings production dependency to 3.3.4
homeassistant/components/smartthings/manifest.json Updates requirements field to specify pysmartthings==3.3.4

"loggers": ["pysmartthings"],
"quality_scale": "bronze",
"requirements": ["pysmartthings==3.3.3"]
"requirements": ["pysmartthings==3.3.4"]
Copy link

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description indicates this is a dependency upgrade for a bugfix, but lacks the required changelog link or version diff as specified in the PR template: 'For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.' Please add a link to the pySmartThings changelog or a diff showing what changed between versions 3.3.3 and 3.3.4 to help reviewers understand what bug is being fixed.

Copilot uses AI. Check for mistakes.
@zweckj zweckj closed this Nov 18, 2025
@zweckj zweckj reopened this Nov 18, 2025
Copy link
Member

@zweckj zweckj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add the changelog/diff to the description

@home-assistant home-assistant bot marked this pull request as draft November 18, 2025 19:31
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copy link
Member

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog/diff is added. Changes look good to me.

@joostlek
Copy link
Member Author

Ho, thanks for adding

@joostlek joostlek marked this pull request as ready for review November 21, 2025 13:10
@home-assistant home-assistant bot requested a review from zweckj November 21, 2025 13:10
@joostlek joostlek merged commit ae38214 into home-assistant:dev Nov 21, 2025
96 of 98 checks passed
@joostlek joostlek deleted the pst-334 branch November 21, 2025 13:10
frenck pushed a commit that referenced this pull request Nov 21, 2025
@frenck frenck mentioned this pull request Nov 21, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants