Reduce number of layers and optimize build of the base-python images #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need the patches in runtime but because they're copied, they are still persisted in a layer of the image. Use bind-mount to have them available only for the build.
There is no major benefit in splitting these two actions to two steps.
By defining it early we're busting the cache on pip version upgrade, effectively making the split into two layers pointless.
Use ensurepip instead of fetching get-pip to install pip, to make the build step simpler. Note that --without-ensurepip in the Python configure args is still desired and correct, as it only prevents from running ensurepip after the build. The ensurepip and upgrade to the pinned version should be run in the same step to prevent layer bloat by modified files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement several low-risk optimization in the *-base-python images to optimize build and reduce layer count by 2. See the individual commits for details.