Skip to content

Conversation

@sairon
Copy link
Member

@sairon sairon commented Nov 25, 2025

Reusable workflow introduced in #328 incorrectly stores the latest versions in GH environment instead of in the output variables. Fix the target variable to correctly tag latest releases again.

Reusable workflow introduced in #328 incorrectly stores the latest versions in
GH environment instead of in the output variables. Fix the target variable to
correctly tag latest releases again.
@sairon sairon requested a review from Copilot November 25, 2025 17:14
Copilot finished reviewing on behalf of sairon November 25, 2025 17:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the reusable workflow where latest version tags were incorrectly stored in the GitHub environment variables instead of output variables. The fix ensures that latest release tagging works correctly by changing the target from $GITHUB_ENV to $GITHUB_OUTPUT in the set-latest step.

  • Changes $GITHUB_ENV to $GITHUB_OUTPUT for storing latest version tags
  • Aligns the implementation with the job's output declarations that reference steps.set-latest.outputs.*
  • Ensures downstream jobs can correctly access the latest version information

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@agners agners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frenck frenck merged commit 8f75fed into master Nov 25, 2025
46 checks passed
@frenck frenck deleted the fix-latest-image-tagging branch November 25, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants