Skip to content

Conversation

@timmo001
Copy link
Member

@timmo001 timmo001 commented Nov 19, 2025

Breaking change

Proposed change

Various style consolidation and fixes for ha-dialog and its usages.

Introduces a container padding to make dialogs conform to safe areas and use padding on the surface instead when on narrow layouts. Swaps between the 2 when layout changes to full mode.

screenrecording-2025-11-20_10-36-05.mp4
screenrecording-2025-11-19_12-12-04.mp4

Also moves more info dialog styles for fixed top to shared area to be reused on other dialogs like the media browser.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes Safe area: ha-dialog #27996
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@timmo001 timmo001 changed the title Add default padding Introduce a container padding for full screen dialogs Nov 19, 2025
@timmo001 timmo001 changed the title Introduce a container padding for full screen dialogs Introduce a container padding for ha-dialog and ha-wa-dialog Nov 19, 2025
@timmo001 timmo001 changed the title Introduce a container padding for ha-dialog and ha-wa-dialog Introduce a container padding for ha-dialog Nov 19, 2025
@timmo001 timmo001 marked this pull request as ready for review November 19, 2025 12:20
@timmo001 timmo001 marked this pull request as draft November 19, 2025 13:44
@timmo001 timmo001 changed the title Introduce a container padding for ha-dialog Fixes for ha-dialog Nov 19, 2025
@timmo001 timmo001 changed the title Fixes for ha-dialog Safe area and styling fixes for ha-dialog Nov 19, 2025
@timmo001 timmo001 force-pushed the safe-area-ha-dialog branch from a2e868b to 4cd5534 Compare November 19, 2025 13:51
@timmo001 timmo001 changed the title Safe area and styling fixes for ha-dialog Standardise fixed top ha-dialog usages and fix safe areas Nov 19, 2025
@timmo001 timmo001 force-pushed the safe-area-ha-dialog branch from 6dcacfd to a2436ad Compare November 20, 2025 08:32
@timmo001 timmo001 marked this pull request as ready for review November 20, 2025 10:58
timmo001 and others added 2 commits November 20, 2025 12:13
Co-authored-by: Petar Petrov <[email protected]>
MindFreeze
MindFreeze previously approved these changes Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Safe area: ha-dialog

3 participants