-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Standardise fixed top ha-dialog usages and fix safe areas #27997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
timmo001
wants to merge
35
commits into
dev
Choose a base branch
from
safe-area-ha-dialog
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a2e868b to
4cd5534
Compare
timmo001
commented
Nov 19, 2025
6dcacfd to
a2436ad
Compare
MindFreeze
reviewed
Nov 20, 2025
Co-authored-by: Petar Petrov <[email protected]>
MindFreeze
reviewed
Nov 20, 2025
MindFreeze
previously approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Various style consolidation and fixes for ha-dialog and its usages.
Introduces a container padding to make dialogs conform to safe areas and use padding on the surface instead when on narrow layouts. Swaps between the 2 when layout changes to full mode.
screenrecording-2025-11-20_10-36-05.mp4
screenrecording-2025-11-19_12-12-04.mp4
Also moves more info dialog styles for fixed top to shared area to be reused on other dialogs like the media browser.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: