Automation editor: Add trigger/condition/action from target #28031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omation-element-by-target
…omation-element-by-target
…omation-element-by-target
…omation-element-by-target
…omation-element-by-target
bramkragten
reviewed
Nov 24, 2025
…omation-element-by-target
bramkragten
reviewed
Nov 25, 2025
src/panels/config/automation/add-automation-element/ha-automation-add-from-target.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+243
to
+245
| const floor = | ||
| entries[ | ||
| `floor${TARGET_SEPARATOR}${this.areas[valueId]?.floor_id || ""}` |
Member
There was a problem hiding this comment.
meaning floor could be undefined right?
Member
Author
There was a problem hiding this comment.
yes then it renders the "Other areas"
| // floor areas, unassigned areas | ||
| if (valueType === "floor") { | ||
| return this._renderAreas( | ||
| entries[`floor${TARGET_SEPARATOR}${valueId ?? ""}`].areas! |
Member
There was a problem hiding this comment.
Can valueId be undefined/null?
Member
Author
There was a problem hiding this comment.
Yes, for all pseudo views like, other areas, devices, services, helpers....
src/panels/config/automation/add-automation-element/ha-automation-add-items.ts
Show resolved
Hide resolved
bramkragten
previously approved these changes
Nov 25, 2025
NoRi2909
reviewed
Nov 26, 2025
bramkragten
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: