Skip to content

Conversation

@ildar170975
Copy link
Contributor

Breaking change

Proposed change

We have places where ha-generic-picker is used nearby other controls.
A left padding (in LTR) for text/icons is different for these components.
This PR sets same padding (16px) for ha-generic-picker.

(unrelated) Also, used a new token for --md-list-item-trailing-space.

Before / After:

image image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ildar170975 ildar170975 marked this pull request as ready for review November 28, 2025 19:32
@Mariusthvdb
Copy link
Contributor

though I fully agree with aligning those, looking much better thx, I do wish we wouldnt keep seeing extra paddings / margins being Added all the time. Seems to be a trend to make the Frontend use more whitespace.

Couldnt this be solved by reducing the padding on the other elements? So we get more space for actual data, like names in those pickers.

@MindFreeze MindFreeze merged commit 0e4cf9f into home-assistant:dev Nov 29, 2025
15 checks passed
@ildar170975 ildar170975 deleted the ha-picker-field-left-padding branch November 29, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants