fix(cameras): change the key from id to serial_number #2491
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
This PR changes the the key from id to serial_number. The key "serial_number" is used in
_find_serial_number_from_nameThis also includes the fix for mypy type checks of instance variables.
fix #2493
How it was tested
Tested with a real hardware.
How to checkout & try? (for the reviewer)
Connect one RealSense and run the following script: