-
-
Notifications
You must be signed in to change notification settings - Fork 77
Integrate swift-configuration #743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #743 +/- ##
==========================================
- Coverage 84.43% 84.39% -0.05%
==========================================
Files 117 121 +4
Lines 7723 7779 +56
==========================================
+ Hits 6521 6565 +44
- Misses 1202 1214 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✅ Pull request no significant performance differences ✅ SummaryNew baseline 'pull_request' is WITHIN the 'main' baseline thresholds. Full Benchmark ComparisonComparing results between 'main' and 'pull_request'RouterRouter:Echo metricsMalloc (total): results within specified thresholds, fold down for details.
Router:GET metricsMalloc (total): results within specified thresholds, fold down for details.
Router:Middleware metricsMalloc (total): results within specified thresholds, fold down for details.
Router:PUT metricsMalloc (total): results within specified thresholds, fold down for details.
Router:Parameters metricsMalloc (total): results within specified thresholds, fold down for details.
RouterBuilder:Middleware metricsMalloc (total): results within specified thresholds, fold down for details.
TrieRouter:LongPaths metricsMalloc (total): results within specified thresholds, fold down for details.
TrieRouter:Parameters metricsMalloc (total): results within specified thresholds, fold down for details.
TrieRouter:Routing metricsMalloc (total): results within specified thresholds, fold down for details.
|
tib
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was quick, @adam-fowler. Looks good to me. Also a great example of how to integrate Swift Configuration using Traits, including Swift version support. 👍
b0d26bf to
f64ea91
Compare
An initial attempt at integrating swift-configuration